From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pxa2xx viper: pcmcia - free gpios on exist rather than requesting them again.
Date: Mon, 06 Jun 2011 15:06:19 +0100 [thread overview]
Message-ID: <4DECDEDB.8090309@arm.com> (raw)
In-Reply-To: <1307368345-13445-2-git-send-email-jic23@cam.ac.uk>
Hi Jonathan,
On 06/06/11 14:52, Jonathan Cameron wrote:
> Signed-off-by: Jonathan Cameron<jic23@cam.ac.uk>
> ---
> drivers/pcmcia/pxa2xx_vpac270.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pcmcia/pxa2xx_vpac270.c b/drivers/pcmcia/pxa2xx_vpac270.c
> index 435002d..413dc7d 100644
> --- a/drivers/pcmcia/pxa2xx_vpac270.c
> +++ b/drivers/pcmcia/pxa2xx_vpac270.c
> @@ -75,10 +75,10 @@ static int vpac270_pcmcia_hw_init(struct soc_pcmcia_socket *skt)
> static void vpac270_pcmcia_hw_shutdown(struct soc_pcmcia_socket *skt)
> {
> if (skt->nr == 0)
> - gpio_request_array(vpac270_pcmcia_gpios,
> + gpio_free_array(vpac270_pcmcia_gpios,
> ARRAY_SIZE(vpac270_pcmcia_gpios));
> else
> - gpio_request_array(vpac270_cf_gpios,
> + gpio_free_array(vpac270_cf_gpios,
> ARRAY_SIZE(vpac270_cf_gpios));
> }
>
You may want to update the subject to reflect the fact that you're
updating the voipac driver, and not the viper one.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2011-06-06 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 13:52 [PATCH 0/2] pxa2xx viper glue code fix + trizeps irrelevant ifdef removal Jonathan Cameron
2011-06-06 13:52 ` [PATCH 1/2] pxa2xx viper: pcmcia - free gpios on exist rather than requesting them again Jonathan Cameron
2011-06-06 14:06 ` Marc Zyngier [this message]
2011-06-06 14:15 ` Jonathan Cameron
2011-06-06 13:52 ` [PATCH 2/2] pxa2xx trizeps4: pcmcia remove unnecessary ifdefs Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DECDEDB.8090309@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.