From: Rolf Meeser <rolfm_9dq@yahoo.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH] snd-usb-audio with multiple audio functions
Date: Mon, 06 Jun 2011 17:17:14 +0200 [thread overview]
Message-ID: <4DECEF7A.80909@yahoo.de> (raw)
In-Reply-To: <s5hipsj1g59.wl%tiwai@suse.de>
Hi Takashi,
On 06/06/2011 11:08 AM, Takashi Iwai wrote:
>> The patch itself looks reasonable to be, and I doubt it would break
>> any existing functions.
> Yeah, I think so, too.
>
I have to disagree :-)
Even worse, I think it is almost nonsense.
Let me figure out another solution which will have to take Clemens'
concerns into account.
>> However, please have a look at Documentation/SubmittingPatches. In
>> particular, you need to have a comprehensive commit log (which can be
>> taken from your explanations in this email) and your "Signed-off-by:"
>> line above the actual patch. Would you care to resend?
> FYI, about sign-off (and in general about the kernel patches), refer
> to $LINUX/Documentation/SubmittingPatches document.
>
I'll submit a clean patch next time!
Regards,
Rolf
next prev parent reply other threads:[~2011-06-06 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 6:49 [PATCH] snd-usb-audio with multiple audio functions Rolf Meeser
2011-06-06 8:45 ` Daniel Mack
2011-06-06 9:08 ` Takashi Iwai
2011-06-06 15:17 ` Rolf Meeser [this message]
2011-06-06 11:44 ` Clemens Ladisch
[not found] ` <4DECC12F.60101@yahoo.de>
2011-06-06 15:47 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DECEF7A.80909@yahoo.de \
--to=rolfm_9dq@yahoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.