From: Chris Friesen <chris.friesen@genband.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [RFC] should we care of COMPAT mode in bridge ?
Date: Mon, 06 Jun 2011 14:23:53 -0600 [thread overview]
Message-ID: <4DED3759.7030209@genband.com> (raw)
In-Reply-To: <20110606.130309.847468074358617705.davem@davemloft.net>
On 06/06/2011 02:03 PM, David Miller wrote:
> From: Eric Dumazet<eric.dumazet@gmail.com>
> Date: Mon, 06 Jun 2011 21:45:40 +0200
>
>> While trying Alexander Holler patch, I found a 32bit brctl program was
>> not able to work on a 64bit kernel. So I had to switch to another
>> machine for my tests.
>>
>> brctl addbr mybridge
>> ->
>> socket(PF_FILE, SOCK_STREAM, 0) = 3
>> ioctl(3, SIOCSIFBR, 0xffd509c0) = -1 EINVAL (Invalid argument)
>>
>> Should we care or not ?
>
> I think we should make an effort to fix this.
For current status of affairs, this makes sense.
It raises an interesting question though...do we plan on supporting
compat indefinitely?
As I see it x86 generally makes more sense to run as 64-bit when
possible due to the extra register availability. Compat is primarily
useful for the embedded space and for backwards compatibility, and
ripping it out would cause a lot of grief for legacy 32-bit apps. It
would simplify the userspace/kernel interface though.
Chris
--
Chris Friesen
Software Developer
GENBAND
chris.friesen@genband.com
www.genband.com
next prev parent reply other threads:[~2011-06-06 20:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 19:45 [RFC] should we care of COMPAT mode in bridge ? Eric Dumazet
2011-06-06 20:03 ` David Miller
2011-06-06 20:23 ` Chris Friesen [this message]
2011-06-06 20:31 ` Arnd Bergmann
2011-06-06 20:31 ` Andreas Schwab
2011-06-06 20:34 ` Eric Dumazet
2011-06-07 23:51 ` Stephen Hemminger
2011-06-08 0:27 ` David Miller
2011-06-08 16:08 ` Stephen Hemminger
2011-06-06 20:06 ` Arnd Bergmann
2011-06-06 20:09 ` David Miller
2011-06-06 20:19 ` Arnd Bergmann
2011-06-06 20:23 ` David Miller
2011-06-07 23:54 ` Stephen Hemminger
2011-06-06 20:12 ` Eric Dumazet
2011-06-06 20:26 ` Arnd Bergmann
2011-06-06 20:32 ` Eric Dumazet
2011-06-06 20:33 ` Arnd Bergmann
2011-06-06 20:35 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DED3759.7030209@genband.com \
--to=chris.friesen@genband.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.