All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] V4L: pxa_camera: remove redundant calculations
Date: Mon, 06 Jun 2011 22:44:43 +0200	[thread overview]
Message-ID: <4DED3C3B.8090804@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.1106061900480.11169@axis700.grange>

On 06/06/2011 07:02 PM, Guennadi Liakhovetski wrote:
> soc_camera core now performs the standard .bytesperline and .sizeimage
> calculations internally, no need to duplicate in drivers.
Haven't I noticed that this patch is twofold :
  - the calculation duplication
  - the suspend/resume change from old suspend/resume to new v4l2_subdev 
power function

Shouldn't this patch have either the commit message amended, or even 
better be split into 2 distinct patches ?

Apart from that, the patch looks ok to me.

--
Robert

  reply	other threads:[~2011-06-06 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 17:02 [PATCH] V4L: pxa_camera: remove redundant calculations Guennadi Liakhovetski
2011-06-06 20:44 ` Robert Jarzmik [this message]
2011-06-06 20:52   ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DED3C3B.8090804@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.