From: Richard Henderson <rth@twiddle.net>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h
Date: Mon, 06 Jun 2011 15:15:42 -0700 [thread overview]
Message-ID: <4DED518E.6090001@twiddle.net> (raw)
In-Reply-To: <CEE0589A-A662-4FE8-81BB-E686E4D6A521@web.de>
On 06/06/2011 10:15 AM, Andreas Färber wrote:
> Am 06.06.2011 um 16:25 schrieb Paolo Bonzini:
>> +#if defined(__arm__) || defined(__sparc__) || defined(__mips__) || defined(__hppa__) || defined(__ia64__)
>> +#define WORDS_ALIGNED
>> +#endif
>
> Since it depends on the host and you're placing it directly under
> config-host.h inclusion, might it make sense to move the decision
> into configure instead, so that it ends up in config-host.h?
Hum, I now understand what Paulo was talking about elsewhere in the thread.
If he takes my suggestion to re-write the unaligned functions with GCC packed
support, these host ifdefs go away, and this objection disappears. The
question becomes one of ordering.
Do we take his existing 3-part patch as-is, and the packed patch as a followup?
Do we convert to packed accesses first and move it around after?
Do we do it all in one step?
r~
next prev parent reply other threads:[~2011-06-06 22:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 14:25 [Qemu-devel] [PATCH v2 0/3] make endian-independent unaligned memory access functions available to libhw Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h Paolo Bonzini
2011-06-06 17:15 ` Andreas Färber
2011-06-06 20:24 ` Paolo Bonzini
2011-06-06 22:15 ` Richard Henderson [this message]
2011-06-07 9:17 ` Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 2/3] softfloat: change default nan definitions to variables Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 3/3] move unaligned memory access functions to bswap.h Paolo Bonzini
2011-06-06 19:56 ` Richard Henderson
2011-06-06 20:27 ` Paolo Bonzini
2011-06-06 22:05 ` Richard Henderson
2011-06-06 23:07 ` malc
2011-06-07 16:54 ` Richard Henderson
2011-06-07 17:29 ` malc
2011-07-06 13:29 ` [Qemu-devel] [PATCH v2 0/3] make endian-independent unaligned memory access functions available to libhw Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DED518E.6090001@twiddle.net \
--to=rth@twiddle.net \
--cc=andreas.faerber@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.