From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751261Ab1FGEAd (ORCPT ); Tue, 7 Jun 2011 00:00:33 -0400 Received: from mail.candelatech.com ([208.74.158.172]:55032 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703Ab1FGEAc (ORCPT ); Tue, 7 Jun 2011 00:00:32 -0400 Message-ID: <4DEDA25C.5010405@candelatech.com> Date: Mon, 06 Jun 2011 21:00:28 -0700 From: Ben Greear Organization: Candela Technologies User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.38.b3pre.fc13 Thunderbird/3.1.9 MIME-Version: 1.0 To: Jesse Barnes CC: Keith Packard , Linux Kernel Mailing List Subject: Re: 3.0.0-rc2 fails to boot on Atom appliance (bisected, drm/i915) References: <4DED33DF.8000201@candelatech.com> <4DED6221.1060806@candelatech.com> <4DED69C6.1090301@candelatech.com> <20110606172402.72ddb29b@jbarnes-desktop> In-Reply-To: <20110606172402.72ddb29b@jbarnes-desktop> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2011 05:24 PM, Jesse Barnes wrote: > On Mon, 06 Jun 2011 16:59:02 -0700 > Ben Greear wrote: > >> On 06/06/2011 04:41 PM, Keith Packard wrote: >>> On Mon, 06 Jun 2011 16:26:25 -0700, Ben Greear wrote: >>>> On 06/06/2011 01:09 PM, Ben Greear wrote: >>>>> Anyone seen something like this? For what it's worth, it seems >>>>> that -rc1 had the same problem. I'll start bisecting soon if >>>>> the problem isn't already resolved somehow... >>>> >>>> I bisected this problem down to this commit: >>> >>> This should be fixed by this patch: >>> >>> -------------------- drivers/gpu/drm/i915/intel_display.c --------------------- >>> index f553ddf..bb1b59b 100644 >>> @@ -7675,6 +7675,7 @@ static void intel_init_display(struct drm_device *dev) >>> dev_priv->display.update_wm = NULL; >>> } else >>> dev_priv->display.update_wm = pineview_update_wm; >>> + dev_priv->display.init_clock_gating = gen3_init_clock_gating; >>> } else if (IS_G4X(dev)) { >>> dev_priv->display.update_wm = g4x_update_wm; >>> dev_priv->display.init_clock_gating = g4x_init_clock_gating; >>> >>> This hasn't been merged yet, but should be soon. >> >> I tried adding that, but the problem stays the same. >> >> Any other patches I should try? > > Are you sure you booted the right kernel and that it built& installed > correctly? I double checked, but I tried to cheat a bit and just applied that patch on top of -rc2 instead of on top of the patch that breaks things according to bisect. Maybe there is more than one problem. I'll try tweaking that single patch tomorrow. And, I built and booted twice to make sure I didn't screw up..but it had been a long day of bisecting, so maybe I still messed up some how. > > You could add an: > if (dev_priv->display.init_clock_gating) > above the call to display.init_clock_gating in intel_init_clock_gating > to be sure it's the same problem... Ok, can try that too. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com