From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqYT-0004Ck-8M for qemu-devel@nongnu.org; Tue, 07 Jun 2011 03:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTqYR-0002vU-Ve for qemu-devel@nongnu.org; Tue, 07 Jun 2011 03:18:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqYR-0002vQ-Og for qemu-devel@nongnu.org; Tue, 07 Jun 2011 03:18:23 -0400 Message-ID: <4DEDD0BA.1080407@redhat.com> Date: Tue, 07 Jun 2011 09:18:18 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1307377259-41434-1-git-send-email-andreas.faerber@web.de> In-Reply-To: <1307377259-41434-1-git-send-email-andreas.faerber@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 00/10] ISA reconfigurability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: hpoussin@reactos.org, qemu-devel@nongnu.org Hi, > This series proposes a new solution: helpers that reconfigure existing ISADevices. > > It also contains a resend of a prerequisite patch with updated summary. > > As for the remaining issue of enabling/disabling devices I'd like to hear > opinions on whether we should allow hot-plugging of these devices or > whether we should add an enabled/disabled state to a qdev device. I'd tend to think having a enable/disable state (and a setstate callback in ISADeviceInfo) is easier to handle, especially wrt the host-side state of the device (i.e. the chardev). Reconfiguration can be done this way then: setstate(0) -> device unregisters irq + ports. qdev_prop_set_*() -> updates iobase + irqs setstate(1) -> device registers new irqs + ports. cheers, Gerd