From: Darren Hart <dvhart@linux.intel.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: y@pokylinux.org, poky@yoctoproject.org
Subject: Re: [PATCH 1/5] kernel.bbclass: Auto load cdc-acm and cdc-wdm
Date: Tue, 07 Jun 2011 09:05:47 -0700 [thread overview]
Message-ID: <4DEE4C5B.7030804@linux.intel.com> (raw)
In-Reply-To: <BANLkTikQH8oxMmMWzrrBjPd_PN_200PUsQ@mail.gmail.com>
On 06/07/2011 05:58 AM, Bruce Ashfield wrote:
> On Tue, Jun 7, 2011 at 4:52 AM, <y@pokylinux.org> wrote:
>> From: Dongxiao Xu <dongxiao.xu@intel.com>
>>
>> Automatically load cdc-acm.ko and cdc-wdm.ko to support 3G module.
>>
>> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
>> ---
>> meta/classes/kernel.bbclass | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 1bb69f5..1b50b38 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -264,6 +264,8 @@ module_autoload_rfcomm = "rfcomm"
>> module_autoload_sa1100-rtc = "sa1100-rtc"
>> # sa1100-rtc was renamed in 2.6.23 onwards
>> module_autoload_rtc-sa1100 = "rtc-sa1100"
>> +module_autoload_cdc-acm = "cdc-acm"
>> +module_autoload_cdc-wdm = "cdc-wdm"
>
> Hi Dongxiao,
>
> This patch should go to oe-core, since we are talking about
> meta/classes/kernel.bbclass.
>
> But seeing this looks like it doesn't belong in kernel.bbclass at all (neither
> do the existing autoloads), but would be better defined in either a BSP or
> distro layer.
Agreed.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2011-06-07 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 8:52 [PATCH 0/5] 3G network support y
2011-06-07 8:52 ` [PATCH 1/5] kernel.bbclass: Auto load cdc-acm and cdc-wdm y
2011-06-07 12:58 ` Bruce Ashfield
2011-06-07 16:05 ` Darren Hart [this message]
2011-06-07 17:05 ` Koen Kooi
2011-06-07 8:52 ` [PATCH 2/5] connman: Upgrade to version 0.73 y
2011-06-07 9:12 ` [poky] " Koen Kooi
2011-06-07 9:12 ` Koen Kooi
2011-06-07 8:52 ` [PATCH 3/5] wpa-supplicant: remove the 0.6.10 version y
2011-06-07 8:52 ` [PATCH 4/5] ofono: add 0.42 version which works OK for Ericsson 3G module y
2011-06-07 8:52 ` [PATCH 5/5] connman-gnome: Add 3G configuration support y
2011-06-07 9:10 ` [poky] [PATCH 0/5] 3G network support Koen Kooi
2011-06-07 9:10 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEE4C5B.7030804@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=bruce.ashfield@gmail.com \
--cc=poky@yoctoproject.org \
--cc=y@pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.