All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <bitbake-devel@lists.openembedded.org>
Subject: Re: RFC: Override expansion - changing the behaviour
Date: Tue, 7 Jun 2011 17:16:24 -0500	[thread overview]
Message-ID: <4DEEA338.6070904@windriver.com> (raw)
In-Reply-To: <1307484603.15327.16.camel@scimitar>

On 6/7/11 5:10 PM, Joshua Lock wrote:
> On Wed, 2011-06-01 at 00:00 +0100, Richard Purdie wrote:
>> Currently if you do:
>>
>> OVERRIDES = "z"
>> DEPENDS_prepend = "a "
>> DEPENDS = "b"
>> DEPENDS_z = "c"
>>
>> d.update_data()
>> d.getVar("DEPENDS") gives "a c"
>> d.update_data()
>> d.getVar("DEPENDS") gives "c"
>>
>> I'm proposing we should change the bitbake behaviour such that at the
>> time bitbake expands the DEPENDS_z override, it removes "DEPENDS_z" from
>> the data store.
> 
> FWIW I think this change is absolutely the right thing to do. The
> current behaviour always catches me out (and I hope I'm not alone) and
> changing it as suggested makes the behaviour much less surprising.
> 
> Cheers,
> Joshua

We will likely need to audit the classes.  I've seen places (in the past, they
may all be gone now) where we've got things like getVar("DEPENDS"), and later
getVar("DEPENDS_${PN}"... where PN is the override...

But more consistent behavior is certainly better..  (Maybe simply clearing the
OVERRIDES, once its been applied is an alternative?)

--Mark



      reply	other threads:[~2011-06-07 23:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 23:00 RFC: Override expansion - changing the behaviour Richard Purdie
2011-06-01 14:59 ` Richard Purdie
2011-06-01 15:51   ` Chris Larson
2011-06-07 22:10 ` Joshua Lock
2011-06-07 22:16   ` Mark Hatle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEEA338.6070904@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.