From: Patrick McHardy <kaber@trash.net>
To: Julian Anastasov <ja@ssi.bg>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_nat: fix crash in nf_nat_csum
Date: Wed, 08 Jun 2011 11:36:18 +0200 [thread overview]
Message-ID: <4DEF4292.2070904@trash.net> (raw)
In-Reply-To: <4DEEADCB.8000803@trash.net>
On 08.06.2011 01:01, Patrick McHardy wrote:
> On 07.06.2011 22:02, Julian Anastasov wrote:
>>
>> Hello,
>>
>> On Tue, 7 Jun 2011, Patrick McHardy wrote:
>>
>>> On 29.05.2011 22:42, Julian Anastasov wrote:
>>>>
>>>> Fix crash in nf_nat_csum when mangling packets
>>>> in OUTPUT hook where skb->dev is not defined, it is set
>>>> later before POSTROUTING. Problem happens for CHECKSUM_NONE.
>>>> We can check device from rt but using CHECKSUM_PARTIAL
>>>> should be safe (skb_checksum_help).
>>>
>>> We don't call helpers in LOCAL_OUT, how can this happen?
>>
>> I think, this happened with IPVS only in OUTPUT hook:
>> tcp_snat_handler -> ip_vs_ftp_out -> nf_nat_mangle_tcp_packet ->
>> nf_nat_csum. This is again PASV FTP via loopback.
>
> I see, thanks. I'll add a comment and will apply this tommorrow.
I must have overlooked the message, just noticed that this patch
is already applied,
prev parent reply other threads:[~2011-06-08 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 20:42 [PATCH] netfilter: nf_nat: fix crash in nf_nat_csum Julian Anastasov
2011-06-07 13:07 ` Patrick McHardy
2011-06-07 20:02 ` Julian Anastasov
2011-06-07 23:01 ` Patrick McHardy
2011-06-08 9:36 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEF4292.2070904@trash.net \
--to=kaber@trash.net \
--cc=ja@ssi.bg \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.