From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUK1Y-0004yF-L2 for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:46:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUK1T-0003CV-Aw for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:46:24 -0400 Received: from goliath.siemens.de ([192.35.17.28]:30518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUK1S-000356-QZ for qemu-devel@nongnu.org; Wed, 08 Jun 2011 10:46:19 -0400 Message-ID: <4DEF8B35.10901@siemens.com> Date: Wed, 08 Jun 2011 16:46:13 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <32d12d55df0a3a98b7f05b3be5e896fe148d59f4.1307528800.git.jan.kiszka@siemens.com> <20110608144313.GS32149@valinux.co.jp> In-Reply-To: <20110608144313.GS32149@valinux.co.jp> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel , "Michael S. Tsirkin" On 2011-06-08 16:43, Isaku Yamahata wrote: > On Wed, Jun 08, 2011 at 12:26:44PM +0200, Jan Kiszka wrote: >> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant >> names to libpci style. Will be used for device assignment code in >> qemu-kvm. > > So since libpci would be used by qemu, you are claiming that > it should be switched to libpci style from Linux pci_regs.h? No, libpci won't be used (I'm about to remove that dependency from qemu-kvm). We are just copying its definitions, so I think we should align to its style. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux