From: Marco Stornelli <marco.stornelli@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
xiyou.wangcong@gmail.com, stevie.trujillo@gmail.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH 2/2 v2] ramoops: add new line to each print
Date: Wed, 08 Jun 2011 21:24:38 +0200 [thread overview]
Message-ID: <4DEFCC76.5050409@gmail.com> (raw)
In-Reply-To: <1307561264.16453.10.camel@Joe-Laptop>
Il 08/06/2011 21:27, Joe Perches ha scritto:
> On Wed, 2011-06-08 at 21:07 +0200, Marco Stornelli wrote:
>> From: Marco Stornelli<marco.stornelli@gmail.com>
>> Add new line to each print.
>> diff --git a/drivers/char/ramoops.c b/drivers/char/ramoops.c
> []
>> @@ -186,6 +188,8 @@ static int __init ramoops_init(void)
>> * if we didn't find a platform device, we use module parameters
>> * building platform data on the fly.
>> */
>> + pr_info("platform device not found, "
>> + "using module parameters\n");
>
> Thanks Marco, I think that looks better.
>
> Trivia:
>
> This fits on a single line and it's not generally a
> good thing to split a format across multiple lines.
>
> cheers, Joe
Mmmm...my editor said 81 cols, so I split the message into two lines.
I'll check it again.
Marco
next prev parent reply other threads:[~2011-06-08 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 14:48 [PATCH 2/2] ramoops: add new line to printks Marco Stornelli
2011-06-07 16:52 ` Marco Stornelli
2011-06-08 16:02 ` Américo Wang
2011-06-08 16:22 ` Joe Perches
2011-06-08 19:07 ` [PATCH 2/2 v2] ramoops: add new line to each print Marco Stornelli
2011-06-08 19:27 ` Joe Perches
2011-06-08 19:24 ` Marco Stornelli [this message]
2011-06-08 19:47 ` [PATCH 2/2 v3] " Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEFCC76.5050409@gmail.com \
--to=marco.stornelli@gmail.com \
--cc=joe@perches.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stevie.trujillo@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.