From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPfi-0003by-3d for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:48:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUPfg-0008QA-Bq for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:48:13 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:54542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPff-0008Q6-PF for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:48:12 -0400 Message-ID: <4DEFE00A.5050005@web.de> Date: Wed, 08 Jun 2011 22:48:10 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <219d3206ad6eafed76d4f108a40912fe72884e19.1307550106.git.jan.kiszka@siemens.com> <20110608195316.GD30805@redhat.com> In-Reply-To: <20110608195316.GD30805@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7CA65943B038CC0081410DDE" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7CA65943B038CC0081410DDE Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-08 21:53, Michael S. Tsirkin wrote: > On Wed, Jun 08, 2011 at 06:21:51PM +0200, Jan Kiszka wrote: >> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant= >> names to libpci style. Will be used for device assignment code in >> qemu-kvm. >> >> Signed-off-by: Jan Kiszka >=20 > Besides keeping pci_regs.h aligned with the original, > I also think ideally pci register banging should stay > within the pci subsystem. >=20 > Could we add high-level APIs to help with that, > instead of having kvm look at config space directly? We could move the related static inlines from msi/msix.c to the headers in order to test for bits etc. Still, kvm needs to interpret the config space of the assigned device, so the abstraction will remain rather low. Jan --------------enig7CA65943B038CC0081410DDE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3v4AoACgkQitSsb3rl5xT8XwCgvKQOHWgoWZTEnnep7dfo9YqR 7SoAoMQMkWipAKA6T3WlkvmtfvraqCHz =AChl -----END PGP SIGNATURE----- --------------enig7CA65943B038CC0081410DDE--