All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Steve Calfee <stevecalfee@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	lrg@ti.com
Subject: Re: [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties
Date: Wed, 8 Jun 2011 17:27:01 -0500	[thread overview]
Message-ID: <4DEFF735.1050301@freescale.com> (raw)
In-Reply-To: <4DEFF270.7050105@gmail.com>

Steve Calfee wrote:
>> Device tree integer properties are encoded in big-endian format, but some of
>> > the Freescale ASoC drivers were assuming that the host is in big-endian format
>> > as well.  Although this is true, it's better to use endian-safe accessors.
> Hi Timur,
> 
> Can this be true?

Yes, it's true.  When the device tree compiler compiles a property that looks
like this:

	fsl,ssi-fifo-depth = <15>;

It writes the following bytes into the dtb:

	00 00 00 0f

> I would assume a software constructed data structure would be in
> host-endian mode.

I wouldn't assume that at all.  The device tree format is a defined binary
format.  It makes sense that the endianness of multi-byte integers is defined.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2011-06-08 22:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 20:02 [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties Timur Tabi
2011-06-08 20:02 ` [PATCH 2/2] ASoC: fsl: fix initialization of DMA buffers Timur Tabi
2011-06-09 10:52   ` Mark Brown
2011-06-09 12:39     ` Tabi Timur-B04825
2011-06-08 22:06 ` [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties Steve Calfee
2011-06-08 22:27   ` Timur Tabi [this message]
2011-06-09  9:45 ` Liam Girdwood
2011-06-09 11:01 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEFF735.1050301@freescale.com \
    --to=timur@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=stevecalfee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.