From: Aneesh V <aneesh@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] OMAP: fix build breaks on OMAP boards
Date: Thu, 09 Jun 2011 13:22:38 +0530 [thread overview]
Message-ID: <4DF07BC6.3030309@ti.com> (raw)
In-Reply-To: <4DEFD9A5.2060009@aribaud.net>
On Thursday 09 June 2011 01:50 AM, Albert ARIBAUD wrote:
> Hi Aneesh,
>
> Le 07/06/2011 17:13, Aneesh V a ?crit :
>> Fix build breaks for OMAP boards.
>> All the build breaks were due to couple of missing
>> defines in the config file, namely:
>>
>> CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
>>
>> They have been fixed by providing the right SDRAM
>> base address and by using SRAM base as the initial
>> stack address.
>>
>> None of these have been tested as I do not have any of
>> these boards.
>>
>> Aneesh V (6):
>> omap1610h2: fix build breaks
>> omap5912osk: fix build breaks
>> omap1510inn: fix build breaks
>> omap1610inn: fix build breaks
>> omap2420h4: fix build breaks
>> omap730p2: fix build breaks
>>
>> include/configs/omap1510inn.h | 3 +++
>> include/configs/omap1610h2.h | 3 +++
>> include/configs/omap1610inn.h | 3 +++
>> include/configs/omap2420h4.h | 3 +++
>> include/configs/omap5912osk.h | 3 +++
>> include/configs/omap730p2.h | 3 +++
>> 6 files changed, 18 insertions(+), 0 deletions(-)
>
> Could you post a V2 series with a symbolic constant rather than a magic
> number for SP? Something like:
>
> ...
> #define PHYS_SRAM 0x20000000
> ...
> #define CONFIG_SYS_INIT_SP_ADDR PHYS_SRAM
>
> ... so that readers of the code know exactly that SP is set to SRAM base.
>
Will do.
Thanks,
Aneesh
next prev parent reply other threads:[~2011-06-09 7:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 15:13 [U-Boot] [PATCH 0/6] OMAP: fix build breaks on OMAP boards Aneesh V
2011-06-07 15:13 ` [U-Boot] [PATCH 1/6] omap1610h2: fix build breaks Aneesh V
2011-06-07 15:13 ` [U-Boot] [PATCH 2/6] omap5912osk: " Aneesh V
2011-06-07 15:13 ` [U-Boot] [PATCH 3/6] omap1510inn: " Aneesh V
2011-06-07 15:13 ` [U-Boot] [PATCH 4/6] omap1610inn: " Aneesh V
2011-06-07 15:13 ` [U-Boot] [PATCH 5/6] omap2420h4: " Aneesh V
2011-06-07 15:13 ` [U-Boot] [PATCH 6/6] omap730p2: " Aneesh V
2011-06-08 20:20 ` [U-Boot] [PATCH 0/6] OMAP: fix build breaks on OMAP boards Albert ARIBAUD
2011-06-09 7:52 ` Aneesh V [this message]
2011-06-09 8:24 ` Aneesh V
2011-06-09 8:24 ` [U-Boot] [PATCH 1/6] omap1610h2: fix build breaks Aneesh V
2011-06-09 8:24 ` [U-Boot] [PATCH 2/6] omap5912osk: " Aneesh V
2011-06-09 8:24 ` [U-Boot] [PATCH 3/6] omap1510inn: " Aneesh V
2011-06-09 8:24 ` [U-Boot] [PATCH 4/6] omap1610inn: " Aneesh V
2011-06-09 8:24 ` [U-Boot] [PATCH 5/6] omap2420h4: " Aneesh V
2011-06-09 8:24 ` [U-Boot] [PATCH 6/6] omap730p2: " Aneesh V
2011-06-09 11:24 ` [U-Boot] [PATCH v3 0/6] OMAP: fix build breaks on OMAP boards Aneesh V
2011-06-13 10:59 ` Albert ARIBAUD
2011-06-13 11:12 ` Aneesh V
2011-06-13 11:17 ` Aneesh V
2011-06-13 11:58 ` Albert ARIBAUD
2011-06-09 11:24 ` [U-Boot] [PATCH v3 1/6] omap1610h2: fix build breaks Aneesh V
2011-06-09 11:24 ` [U-Boot] [PATCH v3 2/6] omap5912osk: " Aneesh V
2011-06-09 11:24 ` [U-Boot] [PATCH v3 3/6] omap1510inn: " Aneesh V
2011-06-09 11:24 ` [U-Boot] [PATCH v3 4/6] omap1610inn: " Aneesh V
2011-06-09 11:24 ` [U-Boot] [PATCH v3 5/6] omap2420h4: " Aneesh V
2011-06-09 11:24 ` [U-Boot] [PATCH v3 6/6] omap730p2: " Aneesh V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF07BC6.3030309@ti.com \
--to=aneesh@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.