From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/4] include/asm/arch-at91: update several .h files to ATMEL_xxx name scheme
Date: Thu, 09 Jun 2011 10:17:07 +0200 [thread overview]
Message-ID: <4DF08183.4070208@emk-elektronik.de> (raw)
In-Reply-To: <1307436509-24126-1-git-send-email-eric@eukrea.com>
Dear Eric B?nard,
> Signed-off-by: Eric B?nard <eric@eukrea.com>
> ---
> arch/arm/include/asm/arch-at91/at91_matrix.h | 10 +++---
> arch/arm/include/asm/arch-at91/at91_rstc.h | 2 +-
> arch/arm/include/asm/arch-at91/at91_wdt.h | 2 +-
> arch/arm/include/asm/arch-at91/at91sam9_sdramc.h | 30 +++++++++++-----------
> arch/arm/include/asm/arch-at91/at91sam9_smc.h | 12 ++++----
> 5 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-at91/at91_matrix.h b/arch/arm/include/asm/arch-at91/at91_matrix.h
> index f99b1d4..a9ba9e9 100644
> --- a/arch/arm/include/asm/arch-at91/at91_matrix.h
> +++ b/arch/arm/include/asm/arch-at91/at91_matrix.h
Several lines are longer than 80 chars. Can you fix this asap?
I think the comments could be left away completely or at least shortened by
removing the obvios "SDAM Controller" part.
Before someone complains about this out of context: those defines are
used by ASM and therefore no struct SoC access is possible in that
case.
Thank you,
Reinhard
> +#define AT91_SDRAMC_MR (ATMEL_BASE_SDRAMC + 0x00) /* SDRAM Controller Mode Register */
> +#define AT91_SDRAMC_TR (ATMEL_BASE_SDRAMC + 0x04) /* SDRAM Controller Refresh Timer Register */
> +#define AT91_SDRAMC_CR (ATMEL_BASE_SDRAMC + 0x08) /* SDRAM Controller Configuration Register */
> +#define AT91_SDRAMC_LPR (ATMEL_BASE_SDRAMC + 0x10) /* SDRAM Controller Low Power Register */
> +#define AT91_SDRAMC_IER (ATMEL_BASE_SDRAMC + 0x14) /* SDRAM Controller Interrupt Enable Register */
> +#define AT91_SDRAMC_IDR (ATMEL_BASE_SDRAMC + 0x18) /* SDRAM Controller Interrupt Disable Register */
> +#define AT91_SDRAMC_IMR (ATMEL_BASE_SDRAMC + 0x1C) /* SDRAM Controller Interrupt Mask Register */
> +#define AT91_SDRAMC_ISR (ATMEL_BASE_SDRAMC + 0x20) /* SDRAM Controller Interrupt Status Register */
> +#define AT91_SDRAMC_MDR (ATMEL_BASE_SDRAMC + 0x24) /* SDRAM Memory Device Register */
next prev parent reply other threads:[~2011-06-09 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 8:48 [U-Boot] [PATCH v2 1/4] include/asm/arch-at91: update several .h files to ATMEL_xxx name scheme Eric Bénard
2011-06-07 8:48 ` [U-Boot] [PATCH v2 2/4] arm926ejs/at91/lowlevel_init.S: fix defines Eric Bénard
2011-06-07 8:48 ` [U-Boot] [PATCH v2 3/4] cpu9260/9G20: fix board support Eric Bénard
2011-06-09 8:29 ` Reinhard Meyer
2011-06-07 8:48 ` [U-Boot] [PATCH v2 4/4] cpuat91: " Eric Bénard
2011-06-09 8:29 ` Reinhard Meyer
2011-06-09 8:17 ` Reinhard Meyer [this message]
2011-06-09 8:25 ` [U-Boot] [PATCH v2 1/4] include/asm/arch-at91: update several .h files to ATMEL_xxx name scheme Eric Bénard
2011-06-09 8:58 ` Reinhard Meyer
2011-06-09 11:13 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF08183.4070208@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.