Re: Question reg. parsing of mtd partitions

[Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>]

On 09.06.2011 12:34, Dmitry Eremin-Solenikov wrote:
> Hello, colleagues,
>
> While doing MTD partitions cleanup I noticed one strange thing.
> parse_mtd_partitions function bears one extra argument (origin)
> which isn't clearly described, set to non-zero only by ixp4xx.c
> driver and then read by redboot partition table handling. I wander if we
> can add some other way to handle this situation and drop this extra 0
> argument from lots of drivers/handlers/etc.
>
> Could you please check it?

At least the ixp4xx part was added by commit f40a6f1cc7fe522,
back in 2006:

If the amount of flash is not divisible by 2 then the mask in
parse_mtd_partitions would fail to work as designed.  Passing in the 
base address corrects this problem.


-- 
With best wishes
Dmitry