From: Liam Girdwood <lrg@ti.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver
Date: Thu, 9 Jun 2011 10:50:58 +0100 [thread overview]
Message-ID: <4DF09782.1090901@ti.com> (raw)
In-Reply-To: <1307606950-8310-3-git-send-email-sbkim73@samsung.com>
On 09/06/11 09:09, Sangbeom Kim wrote:
> I2S in Exynos4 and S5PC110(S5PV210) has a internal dma.
> It can be used low power audio mode and 2nd channel transfer.
>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Looks fine to me, but needs one fix before it can be applied.
Acked-by: Liam Girdwood <lrg@ti.com>
> ---
> sound/soc/samsung/Makefile | 2 +
> sound/soc/samsung/idma.c | 492 ++++++++++++++++++++++++++++++++++++++++++++
> sound/soc/samsung/idma.h | 28 +++
> 3 files changed, 522 insertions(+), 0 deletions(-)
> create mode 100644 sound/soc/samsung/idma.c
> create mode 100644 sound/soc/samsung/idma.h
>
snip
> +
> +static int idma_new(struct snd_card *card,
> + struct snd_soc_dai *dai, struct snd_pcm *pcm)
> +{
This call API has changed in -next.
Thanks
Liam
next prev parent reply other threads:[~2011-06-09 9:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 8:09 [PATCH 0/4] Adding idma driver for samsung SoCs Sangbeom Kim
2011-06-09 8:09 ` [PATCH 1/4] ASoC: SAMSUNG: Modify I2S driver to support idma Sangbeom Kim
2011-06-10 11:31 ` Jassi Brar
2011-06-13 7:58 ` [alsa-devel] " Sangbeom Kim
2011-06-13 8:57 ` Jassi Brar
2011-06-09 8:09 ` [PATCH 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver Sangbeom Kim
2011-06-09 9:50 ` Liam Girdwood [this message]
2011-06-09 23:31 ` Sangbeom Kim
2011-06-09 12:33 ` Kyungmin Park
2011-06-09 23:41 ` [alsa-devel] " Sangbeom Kim
2011-06-10 10:08 ` Jassi Brar
2011-06-13 7:55 ` [alsa-devel] " Sangbeom Kim
2011-06-13 9:07 ` Jassi Brar
2011-06-13 9:40 ` Jassi Brar
2011-06-09 8:09 ` [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs Sangbeom Kim
2011-06-09 10:46 ` Mark Brown
2011-06-09 23:36 ` [alsa-devel] " Sangbeom Kim
2011-06-10 7:03 ` Jassi Brar
2011-06-10 7:16 ` [alsa-devel] " Sangbeom Kim
2011-06-10 7:26 ` Jassi Brar
2011-06-10 9:49 ` [alsa-devel] " Mark Brown
2011-06-10 10:12 ` Jassi Brar
2011-06-10 10:16 ` Mark Brown
2011-06-10 10:43 ` [alsa-devel] " Jassi Brar
2011-06-13 1:47 ` Sangbeom Kim
2011-06-09 8:09 ` [PATCH 4/4] ARM: SAMSUNG: Add platform device for idma Sangbeom Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF09782.1090901@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.