From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH 0/1] Submitting MAX98088 codec patch Date: Thu, 9 Jun 2011 14:51:52 +0100 Message-ID: <4DF0CFF8.1040106@ti.com> References: <20110609104758.GC12865@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by alsa0.perex.cz (Postfix) with ESMTP id 8127B103B52 for ; Thu, 9 Jun 2011 15:51:59 +0200 (CEST) In-Reply-To: <20110609104758.GC12865@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: "Peter.Hsiang@maxim-ic.com" , "alsa-devel@alsa-project.org" , Jassi Brar , Jin Park , "lrg@slimlogic.co.uk" List-Id: alsa-devel@alsa-project.org On 09/06/11 11:47, Mark Brown wrote: > On Thu, Jun 09, 2011 at 05:50:16PM +0900, Jin Park wrote: > >> The max98088 codec driver had unnecessary duplicated codes on DAI operations. >> For example, max98088_dai1_hw_params and max98088_dai2_hw_params, >> they are almost same, except only register offsets. >> So I have combined DAI operations for DAI1 and DAI2. >> Please review my patch. > > Note that there's no need to have a cover letter for a single patch - > any useful information should be in the patch itself. > _______________________________________________ > Acked-by: Liam Girdwood