All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] AT91 rework: pm9261, pm9263 and pm9g45
Date: Thu, 09 Jun 2011 16:10:14 +0200	[thread overview]
Message-ID: <4DF0D446.3040106@emk-elektronik.de> (raw)
In-Reply-To: <4DF0B9C0.2020001@ronetix.at>

Dear Asen Dimov,
> Hello Reinhard,
> 
> On 06/09/2011 01:57 PM, Reinhard Meyer wrote:
> ...
>> Dear Asen Dimov,
>> The empty reset_timer() function added there can obviously only
>> solve build issues.
>> On any account reset_timer() must not be used anymore.
>> As such this patch must get a NAK.
>>
> The architectures, except AT91 are using reset_timer() to make epochs
> (start from zero). I don't want to break the other architectures
> and I need the CFI driver for pm92613 and pm9261. I can not think of
> another idea, except an empty reset_timer(). Any suggestions, ideas?

1. an empty reset_timer() will allow you to build, but at runtime it
must break.

2._if_ the current CFI driver is based on reset_timer()
that should actually be fixed there.
Whereby the actual impact on other architectures that have a broken
get_timer() implementation and therefore _require_ reset_timer() is
unclear to me. We just had a lengthy discussion about timer API etc.
In essence, this discussion, whatever exact API will be implemented,
resulted in NOT having any reset_timer() and only a monotonous,
millisecond returning get_timer() function.

The only _interim_ solution would be to reintroduce the original reset_timer()
to AT91, which I am NOT fond of.

Wolfgang?

Best Regards,
Reinhard

      reply	other threads:[~2011-06-09 14:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09  8:50 [U-Boot] [PATCH] AT91 rework: pm9261, pm9263 and pm9g45 RONETIX - Asen Dimov
2011-06-09 10:57 ` Reinhard Meyer
2011-06-09 11:00   ` Reinhard Meyer
2011-06-09 12:20     ` RONETIX - Asen Dimov
2011-06-09 14:17       ` Reinhard Meyer
2011-06-09 12:17   ` RONETIX - Asen Dimov
2011-06-09 14:10     ` Reinhard Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF0D446.3040106@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.