All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org,
	netdev@vger.kernel.org, Nicolas Cavallari <cavallar@lri.fr>
Subject: Re: [PATCH] netfilter: fix looped (broad|multi)cast's MAC handling.
Date: Thu, 09 Jun 2011 18:08:06 +0200	[thread overview]
Message-ID: <4DF0EFE6.4010206@trash.net> (raw)
In-Reply-To: <1307626748-10992-2-git-send-email-cavallar@lri.fr>

On 09.06.2011 15:39, Nicolas Cavallari wrote:
> By default, when broadcast or multicast packet are sent from a local
> application, they are sent to the interface then looped by the kernel
> to other local applications, going throught netfilter hooks in the process.
> 
> These looped packet have their MAC header removed from the skb by the kernel
> looping code.
> This confuse various netfilter's netlink queue, netlink log and the
> legacy ip_queue, because they try to extract a hardware
> address from these packets, but extracts a part of the IP header instead.
> 
> This patch prevent NFQUEUE, NFLOG and ip_QUEUE to include a MAC header
> if there is none in the packet.

Please add a Signed-off-by: line to your patch so I can apply it.
Thanks!

  reply	other threads:[~2011-06-09 16:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 15:18 [PATCH] netfilter: fix looped (broad|multi)cast's bogus MACs in NFQUEUE Nicolas Cavallari
2011-06-08 15:30 ` Florian Westphal
2011-06-09 13:39   ` Nicolas Cavallari
2011-06-09 13:39     ` [PATCH] netfilter: fix looped (broad|multi)cast's MAC handling Nicolas Cavallari
2011-06-09 16:08       ` Patrick McHardy [this message]
2011-06-10  7:20         ` Nicolas Cavallari
2011-06-16 15:27           ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF0EFE6.4010206@trash.net \
    --to=kaber@trash.net \
    --cc=Nicolas.Cavallari@lri.fr \
    --cc=cavallar@lri.fr \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.