All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] remove lockres from purge list when we are getting it for creating lock
Date: Thu, 09 Jun 2011 18:10:47 -0700	[thread overview]
Message-ID: <4DF16F17.6030100@oracle.com> (raw)
In-Reply-To: <20110610010138.GB3437@laptop.jp.oracle.com>

On 06/09/2011 06:01 PM, Wengang Wang wrote:
>
> Yes, you are right. There is such a problem that the lockres can be
> added to purge list after we drop dlm->spinlock. I am not sure if it's the more
> likely case since there is a 8 seconds delay between the the time the lockres is
> added to purge list and the time it is purged. I guess in normal case, the create-
> lock should already finished in the 8 seconds.
>
> I considered about the inflight_locks. But I didn't think it well so far.
> Because simply moving the lockres out from purge list is not good
> enough, I will take a good think about making use of inflight_locks.
>
>> Secondly, we currently manipulate the purgelist in one function only.
>> __dlm_calc_lockres_usage(). We should stick to that.
> If we make good use of inflight_locks, I think we can.
>> BTW, how are you testing this?
> I tested with the steps which can cause the original problem to prove it
> works.(but without UT).
> Also I made a regression test with the existing ocfs2-test suites(the
> multiple-xxx with reducing interations).

What's UT?

I am looking for is a testcase that reliably reproduces the problem.
Not necessarily that can be checked in. But something that triggers
the issue.

  reply	other threads:[~2011-06-10  1:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 10:04 [Ocfs2-devel] [PATCH] remove lockres from purge list when we are getting it for creating lock Wengang Wang
2011-06-09  5:17 ` Srinivas Eeda
2011-06-09  6:40   ` Wengang Wang
2011-06-09  7:43     ` Srinivas Eeda
2011-06-09  8:10       ` Wengang Wang
2011-06-09 18:34   ` Sunil Mushran
2011-06-10  0:32     ` Wengang Wang
2011-06-10  0:43       ` Sunil Mushran
2011-06-09 17:53 ` Sunil Mushran
2011-06-10  1:01   ` Wengang Wang
2011-06-10  1:10     ` Sunil Mushran [this message]
2011-06-10  1:21       ` Wengang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF16F17.6030100@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.