Re: [PATCH 4/5] NFSv4.1: Add an initialisation callback for pNFS

[Boaz Harrosh <bharrosh@panasas.com>]

On 06/09/2011 06:31 PM, Trond Myklebust wrote:
<snip>
> +void
> +pnfs_generic_pg_init_read(struct nfs_pageio_descriptor *pgio, struct nfs_page *req)
> +{
> +	BUG_ON(pgio->pg_lseg != NULL);
> +
> +	pgio->pg_lseg = pnfs_update_layout(pgio->pg_inode,
> +					   req->wb_context,
> +					   req_offset(req),
> +					   req->wb_bytes,
> +					   IOMODE_READ,
> +					   GFP_KERNEL);
> +}
> +EXPORT_SYMBOL_GPL(pnfs_generic_pg_init_read);
> +
> +void
> +pnfs_generic_pg_init_write(struct nfs_pageio_descriptor *pgio, struct nfs_page *req)
> +{
> +	BUG_ON(pgio->pg_lseg != NULL);
> +
> +	pgio->pg_lseg = pnfs_update_layout(pgio->pg_inode,
> +					   req->wb_context,
> +					   req_offset(req),
> +					   req->wb_bytes,
> +					   IOMODE_RW,
> +					   GFP_NOFS);
> +}
> +EXPORT_SYMBOL_GPL(pnfs_generic_pg_init_write);
> +

These two above are identical except the IOMODE_{READ,RW} variable.
Why don't you just have one and let the caller pass the IOMODE_ as a
3rd parameter. Do you expect more code to be  added here?

Boaz