* v4l2_ctrl_new_std_volatile()?
@ 2011-06-10 8:47 Sakari Ailus
2011-06-10 8:55 ` v4l2_ctrl_new_std_volatile()? Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2011-06-10 8:47 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Laurent Pinchart, linux-media@vger.kernel.org
Hi Hans,
The v4l2_ctrl_new_std() doesn't allow setting the is_volatile bit in the
bit field. The adp1653 driver needs that for the faults control.
Would you prefer just setting the bit in the driver, or, as Laurent
suggested, a new v4l2_ctrl_new_std_volatile() function which would mark
the control as volatile by itself?
Regards,
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: v4l2_ctrl_new_std_volatile()?
2011-06-10 8:47 v4l2_ctrl_new_std_volatile()? Sakari Ailus
@ 2011-06-10 8:55 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2011-06-10 8:55 UTC (permalink / raw)
To: Sakari Ailus; +Cc: Laurent Pinchart, linux-media@vger.kernel.org
On Friday, June 10, 2011 10:47:09 Sakari Ailus wrote:
> Hi Hans,
>
> The v4l2_ctrl_new_std() doesn't allow setting the is_volatile bit in the
> bit field. The adp1653 driver needs that for the faults control.
>
> Would you prefer just setting the bit in the driver, or, as Laurent
> suggested, a new v4l2_ctrl_new_std_volatile() function which would mark
> the control as volatile by itself?
Just set the bit in the driver.
If this will start happening a lot, then we can consider adding a special
function for this, but volatile controls are still pretty rare and I do
not think it warrants a special function just for that.
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-10 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-10 8:47 v4l2_ctrl_new_std_volatile()? Sakari Ailus
2011-06-10 8:55 ` v4l2_ctrl_new_std_volatile()? Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.