All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Devin Nakamura <devin122@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Replaced tabs with spaces in block.h and block_int.h
Date: Fri, 10 Jun 2011 13:09:03 +0200	[thread overview]
Message-ID: <4DF1FB4F.1020700@redhat.com> (raw)
In-Reply-To: <BANLkTi=R9VtWdUoF47s9QxpNbwpHj_f+_Q@mail.gmail.com>

Am 09.06.2011 07:06, schrieb Devin Nakamura:
> Signed-off-by: Devin Nakamura <devin122@gmail.com>
> ---
>  block.h     |    6 +++---
>  block_int.h |    4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/block.h b/block.h
> index da7d39c..859d1d9 100644
> --- a/block.h
> +++ b/block.h
> @@ -110,7 +110,7 @@ int bdrv_check(BlockDriverState *bs, BdrvCheckResult *res);
>  typedef struct BlockDriverAIOCB BlockDriverAIOCB;
>  typedef void BlockDriverCompletionFunc(void *opaque, int ret);
>  typedef void BlockDriverDirtyHandler(BlockDriverState *bs, int64_t sector,
> -				     int sector_num);
> +                                     int sector_num);
>  BlockDriverAIOCB *bdrv_aio_readv(BlockDriverState *bs, int64_t sector_num,
>                                   QEMUIOVector *iov, int nb_sectors,
>                                   BlockDriverCompletionFunc *cb, void *opaque);
> @@ -118,7 +118,7 @@ BlockDriverAIOCB *bdrv_aio_writev(BlockDriverState
> *bs, int64_t sector_num,

The patch is corrupted by this line wrap. This won't happen if you use
git send-email. Stefan posted his config for GMail recently, maybe it
helps you:

> The GMail web interface *always* wraps lines, there doesn't seem to be
> a way to disable that.  If you send it through GMail's SMTP servers
> with git-send-email(1) you'll be fine.
> 
> Here is my .gitconfig:
> [sendemail]
>         smtpserver = smtp.gmail.com
>         smtpserverport = 587
>         smtpencryption = tls
>         smtpuser = stefanha@gmail.com
>         chainreplyto = false

Kevin

  reply	other threads:[~2011-06-10 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09  5:06 [Qemu-devel] [PATCH] Replaced tabs with spaces in block.h and block_int.h Devin Nakamura
2011-06-10 11:09 ` Kevin Wolf [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-06-11  3:26 Devin Nakamura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF1FB4F.1020700@redhat.com \
    --to=kwolf@redhat.com \
    --cc=devin122@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.