Re: [PATCH 2/2] iio: dac: New driver for AD5686R, AD5685R, AD5684R Digital to analog converters

[Jonathan Cameron <jic23@cam.ac.uk>]

...
>>> +}
>>> +
>>> +static ssize_t ad5686_write_dac_powerdown(struct device *dev,
>>> +                                         struct device_attribute *attr,
>>> +                                         const char *buf, size_t len)
>>> +{
>>> +     long readin;
>>> +     int ret;
>>> +     struct iio_dev *indio_dev = dev_get_drvdata(dev);
>>> +     struct ad5686_state *st = iio_priv(indio_dev);
>>> +     struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
>>> +
>> strtobool perhaps? Seems reasonable to write Y to power down the device as well
>> for example.
> That must be a new function. I never saw it before.
> Good match here.

Yup, I added it ;) Got fed up with replicating that functionality all over the place.
As they say, 'scratching an itch...'

>>> +/**
>>> + * struct ad5686_chip_info - chip specific information
>>> + * @int_vref_mv:     AD5620/40/60: the internal reference voltage
>> silly question, but do you have chips to add where this actually varies?
> There might be ones in future.
Then I'd argue for adding it in the future!
>>> +#endif /* SPI_AD5684_H_ */
> Thanks for the review!
You are welcome.  Keep sending me nice drivers like this an I'll be very
happy ;)