From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: KVM: VMX: do not overwrite uptodate vcpu->arch.cr3 on KVM_SET_SREGS
Date: Sun, 12 Jun 2011 11:50:09 +0300 [thread overview]
Message-ID: <4DF47DC1.8000402@redhat.com> (raw)
In-Reply-To: <20110609171123.GA5030@amt.cnet>
On 06/09/2011 08:11 PM, Marcelo Tosatti wrote:
> >
> > Applied and queued, but I think there is something rotten here. How
> > does arch.cr3 get into GUEST_CR3 after KVM_SET_SREGS? arch.cr3 is a
> > supposed to be write-through cache - it only has a bit in
> > regs_avail, not regs_dirty.
>
>
> KVM_SET_SREGS sets good kvm->arch.cr3. Then vmx_decache_cr3 overwrites
> kvm->arch.cr3 from GUEST_CR3, which is stale.
>
Right. Should have called kvm_set_cr3(). It's tricky since we need to
set the order of writing various registers, I'll take a look.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-06-12 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 17:27 KVM: VMX: do not overwrite uptodate vcpu->arch.cr3 on KVM_SET_SREGS Marcelo Tosatti
2011-06-07 8:24 ` Avi Kivity
2011-06-09 17:11 ` Marcelo Tosatti
2011-06-12 8:50 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF47DC1.8000402@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.