Re: [PATCH 1/4] KVM: MMU: Clean up the error handling of walk_addr_generic()

[Avi Kivity <avi@redhat.com>]

On 06/09/2011 05:01 PM, Takuya Yoshikawa wrote:
> From: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>
> Avoid two step jumps to the error handling part.  This eliminates the
> use of the variables present and rsvd_fault.
>
> We also mark the variables write/user/fetch_fault with const to show
> these do not change in the function.
>
> These were suggested by Ingo Molnar.
>   error:
> -	walker->fault.vector = PF_VECTOR;
> -	walker->fault.error_code_valid = true;
> -	walker->fault.error_code = 0;
> -	if (present)
> -		walker->fault.error_code |= PFERR_PRESENT_MASK;
> -
> -	walker->fault.error_code |= write_fault | user_fault;
> -
> +	errcode |= write_fault | user_fault;
>   	if (fetch_fault&&  mmu->nx)
> -		walker->fault.error_code |= PFERR_FETCH_MASK;
> -	if (rsvd_fault)
> -		walker->fault.error_code |= PFERR_RSVD_MASK;
> +		errcode |= PFERR_FETCH_MASK;
>

This area has changed, please regenerate against 'next'.

-- 
error compiling committee.c: too many arguments to function