From: Archit Taneja <archit@ti.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/2] OMAP_VOUT: Create separate file for VRFB related API's
Date: Mon, 13 Jun 2011 12:21:28 +0530 [thread overview]
Message-ID: <4DF5B370.6050500@ti.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739404E2EEFCAA@dbde02.ent.ti.com>
On Monday 13 June 2011 10:13 AM, Hiremath, Vaibhav wrote:
>
>> -----Original Message-----
>> From: Taneja, Archit
>> Sent: Monday, June 13, 2011 10:17 AM
>> To: Hiremath, Vaibhav
>> Cc: linux-media@vger.kernel.org
>> Subject: Re: [PATCH 2/2] OMAP_VOUT: Create separate file for VRFB related
>> API's
>>
>> Hi Vaibhav,
>>
>> On Friday 27 May 2011 12:31 PM, Taneja, Archit wrote:
>>> Introduce omap_vout_vrfb.c and omap_vout_vrfb.h, for all VRFB related
>> API's,
>>> making OMAP_VOUT driver independent from VRFB. This is required for
>> OMAP4 DSS,
>>> since OMAP4 doesn't have VRFB block.
>>>
>>> Added new enum vout_rotation_type and "rotation_type" member to
>> omapvideo_info,
>>> this is initialized based on the arch type in omap_vout_probe. The
>> rotation_type
>>> var is now used to choose between vrfb and non-vrfb calls.
>>
>> Any comments on this patch?
>>
> Archit,
>
> Last week I had to park this due to some high priority issue, today I am going to validate these patches and will respond you.
> Code implementation point of view, this patch looks ok. And I believe you will incorporate my comments on first patch.
Oh okay, great.
Thanks,
Archit
next prev parent reply other threads:[~2011-06-13 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 7:01 [PATCH 0/2] OMAP_VOUT: Allow omap_vout to build without VRFB Archit Taneja
2011-05-27 7:01 ` [PATCH 1/2] OMAP_VOUT: CLEANUP: Move some functions and macros from omap_vout Archit Taneja
2011-06-07 9:05 ` Hiremath, Vaibhav
2011-06-07 9:55 ` Archit Taneja
2011-05-27 7:01 ` [PATCH 2/2] OMAP_VOUT: Create separate file for VRFB related API's Archit Taneja
2011-06-13 4:46 ` Archit Taneja
2011-06-13 4:43 ` Hiremath, Vaibhav
2011-06-13 6:51 ` Archit Taneja [this message]
2011-06-13 18:18 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF5B370.6050500@ti.com \
--to=archit@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.