From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Add weak routes for sidetone style paths
Date: Mon, 13 Jun 2011 18:43:48 +0100 [thread overview]
Message-ID: <4DF64C54.5030209@ti.com> (raw)
In-Reply-To: <1307980397-4035-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 13/06/11 16:53, Mark Brown wrote:
> Normally DAPM will power up any connected audio path. This is not ideal
> for sidetone paths as with sidetone paths the audio path is not wanted in
> itself, it is only desired if the two paths it provides a sidetone between
> are both active. If the sidetone path causes a power up then it can be
> hard to minimise pops as we first power up either the sidetone or the main
> output path and then power the other, with the second power up potentially
> introducing a DC offset.
>
> Address this by introducing the concept of a weak path. If a path is marked
> as weak then DAPM will ignore that path when walking the graph, though all
> the relevant controls are still available to the application layer to allow
> these paths to be configured.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/sound/soc-dapm.h | 2 +
> sound/soc/soc-dapm.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 89 insertions(+), 0 deletions(-)
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-06-13 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 15:53 [PATCH] ASoC: Add weak routes for sidetone style paths Mark Brown
2011-06-13 17:43 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF64C54.5030209@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.