All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"patches@opensource.wolfsonmicro.com"
	<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Don't use codec->control_data in bulk write
Date: Mon, 13 Jun 2011 19:02:20 +0100	[thread overview]
Message-ID: <4DF650AC.6030102@ti.com> (raw)
In-Reply-To: <1307987659-2823-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On 13/06/11 18:54, Mark Brown wrote:
> In order to facilitate merging with the register map I/O replace the use
> of control_data for the bulk writes with direct lookup of the client data
> from the device.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-io.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/soc-io.c b/sound/soc/soc-io.c
> index fbea6c9..cca490c 100644
> --- a/sound/soc/soc-io.c
> +++ b/sound/soc/soc-io.c
> @@ -269,12 +269,12 @@ static int snd_soc_hw_bulk_write_raw(struct snd_soc_codec *codec, unsigned int r
>  	switch (codec->control_type) {
>  #if defined(CONFIG_I2C) || (defined(CONFIG_I2C_MODULE) && defined(MODULE))
>  	case SND_SOC_I2C:
> -		ret = i2c_master_send(codec->control_data, data, len);
> +		ret = i2c_master_send(to_i2c_client(codec->dev), data, len);
>  		break;
>  #endif
>  #if defined(CONFIG_SPI_MASTER)
>  	case SND_SOC_SPI:
> -		ret = spi_write(codec->control_data, data, len);
> +		ret = spi_write(to_spi_device(codec->dev), data, len);
>  		break;
>  #endif
>  	default:

Acked-by: Liam Girdwood <lrg@ti.com>

      reply	other threads:[~2011-06-13 18:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13 17:54 [PATCH] ASoC: Don't use codec->control_data in bulk write Mark Brown
2011-06-13 18:02 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF650AC.6030102@ti.com \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.