From mboxrd@z Thu Jan 1 00:00:00 1970 From: Donggeun Kim Date: Tue, 14 Jun 2011 02:41:39 +0000 Subject: Re: [lm-sensors] [PATCH v6] drivers/hwmon NTC Thermistor Initial Message-Id: <4DF6CA63.70602@samsung.com> List-Id: References: <1307949359-27587-1-git-send-email-dg77.kim@samsung.com> In-Reply-To: <1307949359-27587-1-git-send-email-dg77.kim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: lm-sensors@vger.kernel.org On 2011년 06월 14일 02:06, Guenter Roeck wrote: > On Mon, Jun 13, 2011 at 03:15:59AM -0400, Donggeun Kim wrote: >> This patch adds support for NTC Thermistor series. In this release, the >> following thermistors are supported: NCP15WB473, NCP18WB473, NCP03WB473, >> and NCP15WL333. This driver is based on the datasheet of MURATA. >> >> The driver in the patch does conversion from the raw ADC value >> (either voltage or resistence) to temperature. In order to use >> voltage values as input, the circuit schematics should be provided >> with the platform data. A compensation table for each type of thermistor >> is provided for the conversion. >> >> Signed-off-by: Donggeun Kim >> Signed-off-by: MyungJoo Ham >> Signed-off-by: KyungMin Park >> > Hi folks, > > Almost there. > > [ ... ] > >> include/linux/ntc.h | 53 ++++++ > > Please move this file to include/linux/platform_data/ntc.h. > > One question, though: ntc.[ch] is quite high level and suggests a wider scope than just thermistors. > Would it make sense to use ntc_thermistor.[ch] instead ? > > [ ... ] Okay, I will move and rename the files. >> + if ((data->mintemp != INT_MAX) || (data->maxtemp != INT_MIN)) { > > The inner ( ) are unnecessary. Please remove. > It will be fixed at the next patch. > Thanks, > Guenter > > Thanks for reviewing. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors