All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: Barry Song <Baohua.Song@csr.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
	DL-SHA-APBULinux@csr.com, junyi.zhang@csr.com,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH v2] input: touchscreen: add OF match table for ads7846
Date: Tue, 14 Jun 2011 14:15:12 +0800	[thread overview]
Message-ID: <4DF6FC70.2050707@wytron.com.tw> (raw)
In-Reply-To: <1308015955-8286-1-git-send-email-Baohua.Song@csr.com>

On 06/14/2011 09:45 AM, Barry Song wrote:
> The current ads7846 has no OF match table. The method used is by applying a heuristic (of_modalias_node) which tries to name the device in a way that will match an existing device driver.
> This patch adds explicit OF match table for ads7846, then the normal device tree match behaviour will always work.
> It has been tested on PRIMA2 EVB board of CSR with a SPI's child node like the below:
> ts@0 {
>          compatible = "ti,ads7845";
>          reg =<0x0>;
>          spi-max-frequency =<31250>;
>          interrupts =<90>;
> };
>

Hi Barry,

Thank you very much for your help. Could we add an option for gpio 
pendown, like this?

- gpios : should specify GPIO used for pendown.

If interrupt node is not present in this node, gpio_to_irq of the pen
down GPIO will be used.

Best regards,
Thomas

  reply	other threads:[~2011-06-14  6:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14  1:45 [PATCH v2] input: touchscreen: add OF match table for ads7846 Barry Song
2011-06-14  6:15 ` Thomas Chou [this message]
2011-06-14  6:38   ` Baohua Song
2011-06-15  4:01     ` Thomas Chou
2011-06-15  5:20       ` Baohua Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF6FC70.2050707@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=Baohua.Song@csr.com \
    --cc=DL-SHA-APBULinux@csr.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=junyi.zhang@csr.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.