From: Jan Kiszka <jan.kiszka@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Reset system before loadvm
Date: Tue, 14 Jun 2011 08:16:44 +0200 [thread overview]
Message-ID: <4DF6FCCC.3030803@web.de> (raw)
In-Reply-To: <BANLkTinbeXYnDXoTueY9G4gSzF7LB8i8Nw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On 2011-06-12 19:42, Peter Maydell wrote:
> On 11 June 2011 10:05, Jan Kiszka <jan.kiszka@web.de> wrote:
>> @@ -2074,6 +2074,7 @@ int load_vmstate(const char *name)
>> return -EINVAL;
>> }
>>
>> + qemu_system_reset();
>> ret = qemu_loadvm_state(f);
>
> This means that if we're doing a load because the user
> passed -loadvm on the command line we'll end up doing
> qemu_system_reset() twice (once in vl.c and then again
> here). Does that matter?
I don't think it's worth optimizing. E.g. we already reset every PCI
device twice during normal reset.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-06-14 6:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 9:05 [Qemu-devel] [PATCH] Reset system before loadvm Jan Kiszka
2011-06-12 17:13 ` Avi Kivity
2011-06-14 6:19 ` Jan Kiszka
2011-06-14 10:50 ` Avi Kivity
2011-06-14 10:56 ` Jan Kiszka
2011-06-14 11:14 ` Avi Kivity
2011-06-14 15:45 ` Luiz Capitulino
2011-06-12 17:42 ` Peter Maydell
2011-06-14 6:16 ` Jan Kiszka [this message]
2011-06-14 16:29 ` [Qemu-devel] [PATCH 1/2] Allow silent system resets Jan Kiszka
2011-06-15 14:32 ` Luiz Capitulino
2011-06-14 16:29 ` [Qemu-devel] [PATCH v2 2/2] Reset system before loadvm Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF6FCCC.3030803@web.de \
--to=jan.kiszka@web.de \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.