From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q8OpZHJpYyBDYW5v?= Subject: Re: [PATCH 1/1] Big endian swap for Marvell 6440 SAS driver Date: Tue, 14 Jun 2011 08:42:59 +0200 Message-ID: <4DF702F3.704@interfaceconcept.com> References: <4DF2228E.7060806@ic.fr> <1307832356.2874.312.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1307832356.2874.312.camel@pasglop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org To: Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org SGkgQmVuLAoKWW91J3JlIGFscmlnaHQhIEkgaGFkbid0IHRob3VnaHQgdG8gdXNlIGxlMzJfdG9f Y3B1LgpEbyB5b3Ugd2FudCBJIG1ha2UgYSBuZXcgcGF0Y2g/CgpDZWRyaWMKCkxlIDEyLzA2LzIw MTEgMDA6NDUsIEJlbmphbWluIEhlcnJlbnNjaG1pZHQgYSDDqWNyaXQgOgo+IE9uIEZyaSwgMjAx MS0wNi0xMCBhdCAxNTo1NiArMDIwMCwgQ8OpZHJpYyBDYW5vIHdyb3RlOgo+PiBIaSwKPj4KPj4g TWFydmVsbCBTQVMgZHJpdmVyIGRvZXNuJ3Qgd29yayBvbiBwb3dlcnBjIGFyY2hpdGVjdHVyZSBk dWUgdG8gYmlnCj4+IGVuZGlhbiBzd2FwLiBJJ3ZlIHRlc3RlZCBpdCB3aXRoIHRoZSBNVjY0NDAg Y2hpcC4KPj4gSGVyZSB5b3UgY2FuIGZpbmQgdGhlIHBhdGNoIGZvciBMaW51eCAyLjYuMzkuMS4K Pj4KPj4gQ2VkcmljIENhbm8KPj4KPj4gU2lnbmVkLW9mZi1ieTogQ2VkcmljIENhbm88Y2Nhbm9A aW50ZXJmYWNlY29uY2VwdC5jb20+Cj4+IC0tLQo+PiAtLS0gZHJpdmVycy9zY3NpL212c2FzL212 X3Nhcy5jICAgIDIwMTEtMDYtMTAgMTU6NTA6MDQuMDAwMDAwMDAwICswMjAwCj4+ICsrKyBkcml2 ZXJzL3Njc2kvbXZzYXMvbXZfc2FzLmMgICAgMjAxMS0wNi0xMCAxNTo1MDoxMi4wMDAwMDAwMDAg KzAyMDAKPj4gQEAgLTExNDMsNiArMTE0MywxNCBAQAo+PiAgICAgICAgTVZTX0NISVBfRElTUC0+ d3JpdGVfcG9ydF9jZmdfYWRkcihtdmksIGksIFBIWVJfU0FUQV9TSUcwKTsKPj4gICAgICAgIHNb MF0gPSBNVlNfQ0hJUF9ESVNQLT5yZWFkX3BvcnRfY2ZnX2RhdGEobXZpLCBpKTsKPj4KPj4gKyAg ICAvKiBzd2FwIGZvciBiaWcgZW5kaWFuIGRldmljZXMgYmVjYXVzZSBvZiB1c2Ugb2YgdGhlc2Ug ZGF0YSBpbiBieXRlcyAqLwo+PiArI2lmZGVmIF9fQklHX0VORElBTgo+PiArICAgIHNbMF0gPSBz d2FiMzIoc1swXSk7Cj4+ICsgICAgc1sxXSA9IHN3YWIzMihzWzFdKTsKPj4gKyAgICBzWzJdID0g c3dhYjMyKHNbMl0pOwo+PiArICAgIHNbM10gPSBzd2FiMzIoc1szXSk7Cj4+ICsjZW5kaWYgLyog X19CSUdfRU5ESUFOICovCj4gSGkgQ2VkcmljICEKPgo+IFRoYW5rcyBmb3IgdGhpcy4gQ0MnaW5n IGxpbnV4LXNjc2kuCj4KPiBOb3RlIHRoYXQgaXQgd291bGQgcHJvYmFibHkgaGF2ZSBiZWVuIGJl dHRlciB0byB1c2UgbGUzMl90b19jcHUsIHdoaWNoCj4gYXZvaWRzIHRoZSBpZmRlZiBjb21wbGV0 ZWx5Lgo+Cj4gQ2hlZXJzLAo+IEJlbi4KPgo+PiAgICAgICAgLyogV29ya2Fyb3VuZDogdGFrZSBz b21lIEFUQVBJIGRldmljZXMgZm9yIEFUQSAqLwo+PiAgICAgICAgaWYgKCgoc1sxXSYgIDB4MDBG RkZGRkYpID09IDB4MDBFQjE0MDEpJiYgICgqKHU4ICopJnNbM10gPT0gMHgwMSkpCj4+ICAgICAg ICAgICAgc1sxXSA9IDB4MDBFQjE0MDEgfCAoKigodTggKikmc1sxXSArIDMpJiAgMHgxMCk7Cj4+ Cj4+IC0tLQo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+PiBMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0Cj4+IExpbnV4cHBjLWRldkBsaXN0cy5vemxh YnMub3JnCj4+IGh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXYK Pgo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4 cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcKaHR0cHM6 Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRldg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out05.msg.oleane.net (smtp-out05.msg.oleane.net [62.161.7.3]) by ozlabs.org (Postfix) with ESMTP id 74327B6FB9 for ; Tue, 14 Jun 2011 17:04:25 +1000 (EST) Message-ID: <4DF702F3.704@interfaceconcept.com> Date: Tue, 14 Jun 2011 08:42:59 +0200 From: =?UTF-8?B?Q8OpZHJpYyBDYW5v?= MIME-Version: 1.0 To: Benjamin Herrenschmidt Subject: Re: [PATCH 1/1] Big endian swap for Marvell 6440 SAS driver References: <4DF2228E.7060806@ic.fr> <1307832356.2874.312.camel@pasglop> In-Reply-To: <1307832356.2874.312.camel@pasglop> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Ben, You're alright! I hadn't thought to use le32_to_cpu. Do you want I make a new patch? Cedric Le 12/06/2011 00:45, Benjamin Herrenschmidt a écrit : > On Fri, 2011-06-10 at 15:56 +0200, Cédric Cano wrote: >> Hi, >> >> Marvell SAS driver doesn't work on powerpc architecture due to big >> endian swap. I've tested it with the MV6440 chip. >> Here you can find the patch for Linux 2.6.39.1. >> >> Cedric Cano >> >> Signed-off-by: Cedric Cano >> --- >> --- drivers/scsi/mvsas/mv_sas.c 2011-06-10 15:50:04.000000000 +0200 >> +++ drivers/scsi/mvsas/mv_sas.c 2011-06-10 15:50:12.000000000 +0200 >> @@ -1143,6 +1143,14 @@ >> MVS_CHIP_DISP->write_port_cfg_addr(mvi, i, PHYR_SATA_SIG0); >> s[0] = MVS_CHIP_DISP->read_port_cfg_data(mvi, i); >> >> + /* swap for big endian devices because of use of these data in bytes */ >> +#ifdef __BIG_ENDIAN >> + s[0] = swab32(s[0]); >> + s[1] = swab32(s[1]); >> + s[2] = swab32(s[2]); >> + s[3] = swab32(s[3]); >> +#endif /* __BIG_ENDIAN */ > Hi Cedric ! > > Thanks for this. CC'ing linux-scsi. > > Note that it would probably have been better to use le32_to_cpu, which > avoids the ifdef completely. > > Cheers, > Ben. > >> /* Workaround: take some ATAPI devices for ATA */ >> if (((s[1]& 0x00FFFFFF) == 0x00EB1401)&& (*(u8 *)&s[3] == 0x01)) >> s[1] = 0x00EB1401 | (*((u8 *)&s[1] + 3)& 0x10); >> >> --- >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/linuxppc-dev > >