From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kenneth Graunke <kenneth@whitecape.org>
Subject: Re: [PATCH] drm/i915: use BLT ring for flips on IVB
Date: Tue, 14 Jun 2011 00:14:11 -0700
Message-ID: <4DF70A43.4040804@whitecape.org>
References: <1307646877-1979-1-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from homiemail-a5.g.dreamhost.com (caiajhbdcaid.dreamhost.com
	[208.97.132.83])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2D2F29E93F
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 13 Jun 2011 15:17:43 -0700 (PDT)
Received: from homiemail-a5.g.dreamhost.com (localhost [127.0.0.1])
	by homiemail-a5.g.dreamhost.com (Postfix) with ESMTP id A24F270406F
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 13 Jun 2011 15:17:42 -0700 (PDT)
Received: from [192.168.1.153] (fruit.freedesktop.org [131.252.210.190])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: kenneth@whitecape.org)
	by homiemail-a5.g.dreamhost.com (Postfix) with ESMTPSA id 76CD370406E
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 13 Jun 2011 15:17:42 -0700 (PDT)
In-Reply-To: <1307646877-1979-1-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 06/09/2011 12:14 PM, Jesse Barnes wrote:
> Found a couple more problems:
>    1) MI_DISPLAY_FLIP should take a '1' in the last byte to indicate
>       length on IVB
>    2) apprently only the BLT ring version of the command actually causes
>       interrupts to be generated
>
> With this patch, modetest -v works on my test platform.  Clearly it's in
> need of more splitting though.  The case statement should be split into
> per-chipset flip command generation.
>
> Signed-off-by: Jesse Barnes<jbarnes@virtuousgeek.org>

Reviewed-and-tested-by: Kenneth Graunke <kenneth@whitecape.org>

Compiz runs with this patch and appears to be mostly working.

Thanks, Jesse!