From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kenneth Graunke <kenneth@whitecape.org>
Subject: Re: [PATCH] drm/i915: use BLT ring for flips on IVB
Date: Tue, 14 Jun 2011 00:29:08 -0700
Message-ID: <4DF70DC4.1060801@whitecape.org>
References: <1307646877-1979-1-git-send-email-jbarnes@virtuousgeek.org>
	<4DF70A43.4040804@whitecape.org>
	<f80fcd$guqsv@fmsmga001.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from homiemail-a10.g.dreamhost.com (caiajhbdcbbj.dreamhost.com
	[208.97.132.119])
	by gabe.freedesktop.org (Postfix) with ESMTP id 90C819E75E
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 13 Jun 2011 15:32:43 -0700 (PDT)
In-Reply-To: <f80fcd$guqsv@fmsmga001.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 06/13/2011 03:22 PM, Chris Wilson wrote:
> On Tue, 14 Jun 2011 00:14:11 -0700, Kenneth Graunke<kenneth@whitecape.org>  wrote:
>> On 06/09/2011 12:14 PM, Jesse Barnes wrote:
>>> Found a couple more problems:
>>>     1) MI_DISPLAY_FLIP should take a '1' in the last byte to indicate
>>>        length on IVB
>>>     2) apprently only the BLT ring version of the command actually causes
>>>        interrupts to be generated
>>>
>>> With this patch, modetest -v works on my test platform.  Clearly it's in
>>> need of more splitting though.  The case statement should be split into
>>> per-chipset flip command generation.
>>>
>>> Signed-off-by: Jesse Barnes<jbarnes@virtuousgeek.org>
>>
>> Reviewed-and-tested-by: Kenneth Graunke<kenneth@whitecape.org>
>
> But it's not the neatest patch in the world ;-)

True :)

> Using struct intel_ring_buffer *ring for all generation and switching
> between blt/render on demand should be neater. Also we should be able
> to do pageflips from either the render or blt ring on gen7, right? That
> will be useful to avoid a synchronisation point.
> -Chris

I thought so, from reading the docs.  But it doesn't seem to work from 
the render ring...

--Kenneth