From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH v2 00/11] KVM in-guest performance monitoring Date: Tue, 14 Jun 2011 12:11:02 -0600 Message-ID: <4DF7A436.8090308@cisco.com> References: <1307972106-2468-1-git-send-email-avi@redhat.com> <4DF66B1A.6060606@cisco.com> <4DF71DA3.2080300@redhat.com> <4DF7972F.3040103@cisco.com> <4DF79941.9050705@siemens.com> <4DF79B6F.10102@cisco.com> <4DF79EFE.1050201@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo To: Avi Kivity Return-path: Received: from sj-iport-1.cisco.com ([171.71.176.70]:44032 "EHLO sj-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491Ab1FNSLE (ORCPT ); Tue, 14 Jun 2011 14:11:04 -0400 In-Reply-To: <4DF79EFE.1050201@cisco.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/14/2011 11:48 AM, David Ahern wrote: > On 06/14/2011 11:33 AM, David Ahern wrote: >> Avi: still no luck: >> [ 0.047996] Performance Events: unsupported p6 CPU model 0 no PMU >> driver, software events only. >> >> qemu-kvm next branch, ce5f0a588b740e8f28f46a6009e12cfa72edc51f with your >> perfmon cpuid change. Host and guest are both running your kvm next >> branch with pmu patch series. > > The perf init code is going down the !perfmon route: > > if (!cpu_has(&boot_cpu_data, X86_FEATURE_ARCH_PERFMON)) { > switch (boot_cpu_data.x86) { > case 0x6: > return p6_pmu_init(); > case 0xf: > return p4_pmu_init(); > } > return -ENODEV; > } > > Based on Patch 2 you are expecting the guest to have this feature set. > I've tried +perfmon and +arch_perfmon in the cpu definition for qemu-kvm > (e.g., -cpu host,model=0,+perfmon) no luck > nevermind. I hand applied your qemu-kvm patch and changed ebx not eax. I noticed init_intel() looked at eax and discovered the user error. Application of patch fixed and it works. :-) David