All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J.H." <warthog9@eaglescrag.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Ludwig Nussel <ludwig.nussel@suse.de>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: allow space as delimiter in mime.types
Date: Tue, 14 Jun 2011 12:30:52 -0700	[thread overview]
Message-ID: <4DF7B6EC.6010504@eaglescrag.net> (raw)
In-Reply-To: <m3ips8v4s2.fsf@localhost.localdomain>

On 06/14/2011 07:59 AM, Jakub Narebski wrote:
> Ludwig Nussel <ludwig.nussel@suse.de> writes:
> 
>> Subject: [PATCH] gitweb: allow space as delimiter in mime.types
> 
> A very minor nitpick: perhaps "work with" rather than "allow" would be
> better?
> 
>> in openSUSE /etc/mime.types has only spaces. I don't know if there's
>> a canonical reference that says that only tabs are allowed. Mutt at
>> least also accepts spaces. So make gitweb more liberal too.
> 
> Ack.
> 
> It is obviously correct, as names of MUME types cannot contain spaces,
> it makes gitweb work with openSUSE /etc/mime.types, and it makes code
> simpler.

I agree with Jakub, Ack.

- John 'Warthog9' Hawley

  reply	other threads:[~2011-06-14 19:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 14:09 [PATCH] gitweb: allow space as delimiter in mime.types Ludwig Nussel
2011-06-14 14:59 ` Jakub Narebski
2011-06-14 19:30   ` J.H. [this message]
2011-06-14 21:28   ` Junio C Hamano
2011-06-15  6:10     ` [PATCH v2] " Ludwig Nussel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF7B6EC.6010504@eaglescrag.net \
    --to=warthog9@eaglescrag.net \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=ludwig.nussel@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.