From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 1/8] ASoC: AD1836: drop unnecessary spi register check Date: Tue, 14 Jun 2011 23:55:22 +0200 Message-ID: <4DF7D8CA.10909@metafoo.de> References: <1308087268-11464-1-git-send-email-vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailhost.informatik.uni-hamburg.de (mailhost.informatik.uni-hamburg.de [134.100.9.70]) by alsa0.perex.cz (Postfix) with ESMTP id C65122440D for ; Tue, 14 Jun 2011 23:56:40 +0200 (CEST) In-Reply-To: <1308087268-11464-1-git-send-email-vapier@gentoo.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mike Frysinger Cc: alsa-devel@alsa-project.org, Mark Brown , device-drivers-devel@blackfin.uclinux.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On 06/14/2011 11:34 PM, Mike Frysinger wrote: > The only thing the init func does is register a spi driver, so if that > fails, we return the value back up to the caller who will display an > error message for us. So drop the redundant checking/message. > > Signed-off-by: Mike Frysinger > --- > sound/soc/codecs/ad1836.c | 10 +--------- > 1 files changed, 1 insertions(+), 9 deletions(-) > > diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c > index 754c496..d368539 100644 > --- a/sound/soc/codecs/ad1836.c > +++ b/sound/soc/codecs/ad1836.c > [...] Mike, most of these patches won't apply, since I already submitted support for the other AD183X chips last week. Please check Mark's for-next branch. - Lars