From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWkVU-0003S5-JH for qemu-devel@nongnu.org; Wed, 15 Jun 2011 03:27:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWkVS-0002wr-Mx for qemu-devel@nongnu.org; Wed, 15 Jun 2011 03:27:20 -0400 Received: from thoth.sbs.de ([192.35.17.2]:26513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWkVS-0002wd-62 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 03:27:18 -0400 Message-ID: <4DF85ED4.5050204@siemens.com> Date: Wed, 15 Jun 2011 09:27:16 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1308081188-19695-1-git-send-email-rth@twiddle.net> In-Reply-To: <1308081188-19695-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH, v2] vga: Fix type of lfb/map_addr/end. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: "qemu-devel@nongnu.org" On 2011-06-14 21:53, Richard Henderson wrote: > These addresses have been passed through pci_to_cpu_addr, > and thus need to be full target_phys_addr_t. > > Signed-off-by: Richard Henderson > Cc: Jan Kiszka > --- > > V1->V2: > lfb_addr/end also widened to guest address width. > > hw/vga_int.h | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/vga_int.h b/hw/vga_int.h > index d2811bd..eee91a8 100644 > --- a/hw/vga_int.h > +++ b/hw/vga_int.h > @@ -106,13 +106,13 @@ typedef void (* vga_update_retrace_info_fn)(struct VGACommonState *s); > typedef struct VGACommonState { > uint8_t *vram_ptr; > ram_addr_t vram_offset; > + target_phys_addr_t lfb_addr; > + target_phys_addr_t lfb_end; > + target_phys_addr_t map_addr; > + target_phys_addr_t map_end; > uint32_t vram_size; > - uint32_t lfb_addr; > - uint32_t lfb_end; > - uint32_t map_addr; > - uint32_t map_end; > - uint32_t lfb_vram_mapped; /* whether 0xa0000 is mapped as ram */ > uint32_t latch; > + uint32_t lfb_vram_mapped; /* whether 0xa0000 is mapped as ram */ > uint8_t sr_index; > uint8_t sr[256]; > uint8_t gr_index; Acked-by: Jan Kiszka But one of us will have to rebase at the end of the day. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux