From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: sdhci: rework Samsung specfic code
Date: Wed, 15 Jun 2011 17:12:13 +0900 [thread overview]
Message-ID: <4DF8695D.3010403@samsung.com> (raw)
In-Reply-To: <BANLkTimQc=yXeC5tMv61+sge7URG6sm6EQ@mail.gmail.com>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
But Mr.Kang mentioned missing arch/arm/include/asm/arch-s5pc1xx/cpu.h
Need the below patch..
(s5pc2xx and s5pc1xx are working well)
diff --git a/arch/arm/include/asm/arch-s5pc1xx/cpu.h b/arch/arm/include/asm/arch-s5pc1xx/cpu.h
index e74959f..86b7bd2 100644
--- a/arch/arm/include/asm/arch-s5pc1xx/cpu.h
+++ b/arch/arm/include/asm/arch-s5pc1xx/cpu.h
@@ -94,6 +94,9 @@ SAMSUNG_BASE(mmc, MMC_BASE)
SAMSUNG_BASE(sromc, SROMC_BASE)
SAMSUNG_BASE(timer, PWMTIMER_BASE)
SAMSUNG_BASE(uart, UART_BASE)
+
+#define samsung_get_base_mmc_offset(idx) (samsung_get_base_mmc() + \
+ 0x10000 * (idx))
#endif
#endif /* _S5PC1XX_CPU_H */
Regards,
Jaehoon Chung
Minkyu Kang wrote:
> Dear Rob Herring,
>
> On 14 June 2011 23:48, Rob Herring <robherring2@gmail.com> wrote:
>> arch/arm/include/asm/arch-s5pc1xx/mmc.h | 73 ------------------------------
>> arch/arm/include/asm/arch-s5pc2xx/cpu.h | 4 ++
>> arch/arm/include/asm/arch-s5pc2xx/mmc.h | 73 ------------------------------
>> board/samsung/goni/goni.c | 4 +-
>> board/samsung/universal_c210/universal.c | 6 +-
>> drivers/mmc/sdhci.c | 31 +++++++------
>> include/sdhci.h | 62 +++++++++++++++++++++++++
>> 7 files changed, 88 insertions(+), 165 deletions(-)
>> delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h
>> delete mode 100644 arch/arm/include/asm/arch-s5pc2xx/mmc.h
>> create mode 100644 include/sdhci.h
>>
>> --- a/arch/arm/include/asm/arch-s5pc2xx/cpu.h
>> +++ b/arch/arm/include/asm/arch-s5pc2xx/cpu.h
>> @@ -108,6 +108,10 @@ SAMSUNG_BASE(uart, UART_BASE)
>> SAMSUNG_BASE(usb_phy, USBPHY_BASE)
>> SAMSUNG_BASE(usb_otg, USBOTG_BASE)
>> SAMSUNG_BASE(watchdog, WATCHDOG_BASE)
>> +
>> +#define samsung_get_base_mmc_offset(idx) (samsung_get_base_mmc() + \
>> + 0x10000 * (idx))
>> +
>> #endif
>>
>> #endif /* _S5PC2XX_CPU_H */
>
> Looks fine.
> But, missing arch/arm/include/asm/arch-s5pc1xx/cpu.h
>
> Dear Jaehoon,
>
> Please test this patch on s5pc1xx and s5pc2xx.
>
> Thanks
> Minkyu Kang
next prev parent reply other threads:[~2011-06-15 8:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 21:46 [U-Boot] [PATCH 0/8] Add Highbank platform Rob Herring
2011-06-11 21:46 ` [U-Boot] [PATCH 1/8] mmc: copy s5p to sdhci Rob Herring
2011-06-11 21:46 ` [U-Boot] [PATCH 2/8] mmc: sdhci: rework Samsung specfic code Rob Herring
2011-06-13 6:59 ` Minkyu Kang
2011-06-13 12:45 ` Rob Herring
2011-06-14 8:14 ` Minkyu Kang
2011-06-14 14:48 ` [U-Boot] [PATCH] " Rob Herring
2011-06-15 4:28 ` Minkyu Kang
2011-06-15 8:12 ` Jaehoon Chung [this message]
2011-06-15 8:29 ` Minkyu Kang
2011-06-15 8:40 ` Jaehoon Chung
2011-06-13 21:01 ` [U-Boot] [PATCH 2/8] " Mike Frysinger
2011-06-11 21:46 ` [U-Boot] [PATCH 3/8] mmc: sdhci: exit cmd on error status Rob Herring
2011-06-11 21:46 ` [U-Boot] [PATCH 4/8] arm: add __ilog2 function Rob Herring
2011-06-11 21:46 ` [U-Boot] [PATCH 5/8] scsi/ahci: ata id little endian fix Rob Herring
2011-06-11 21:46 ` [U-Boot] [PATCH 6/8] scsi/ahci: add support for non-PCI controllers Rob Herring
2011-06-11 21:46 ` [U-Boot] [PATCH 7/8] ARM: add missing CONFIG_SKIP_LOWLEVEL_INIT for armv7 Rob Herring
2011-07-17 9:26 ` Albert ARIBAUD
2011-06-11 21:46 ` [U-Boot] [PATCH 8/8] ARM: Add Calxeda Highbank platform Rob Herring
2011-07-17 9:29 ` Albert ARIBAUD
2011-07-17 9:42 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8695D.3010403@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.