All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Jingdong Lu <jingdong.lu@windriver.com>
Cc: yocto@yoctoproject.org, Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH 0/1] Enable to set RTC for beagleboard
Date: Wed, 15 Jun 2011 09:21:27 -0400	[thread overview]
Message-ID: <4DF8B1D7.8050208@windriver.com> (raw)
In-Reply-To: <cover.1308133815.git.jingdong.lu@windriver.com>

On 06/15/11 06:41, Jingdong Lu wrote:
> From: Jingdong Lu<jingdong.lu@windriver.com>
>
> Ensure msecure is mux'd to be able to set the RTC for beagleboard.
> Fixes bug [YOCTO #767]

Jingdong,

The fix looks reasonable to me, Darren has been refreshing
the beagleboard support as well, so I've cc'd him here to
see if we have this change present in the work in progress
trees.

What tests did you run to ensure that the RTC worked on
the beagleboard ? There was some debate around whether or
not you needed an add-on card to get this functionality
available ?

Also for for any beagleboard changes, we should:

   - check the various upstream trees and use their commits
     if possible. Or if you've checked and couldn't find
     anything. State that in the patch submission.

   - reference the test platform details. Rev of the board,
     the model, etc.

Thanks for the patch, we just need to do a bit more
checking on it before we can get it into the tree.

Cheers,

Bruce

>
> Jingdong Lu (1):
>    RTC: Enable to set RTC
>
>   arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto



  parent reply	other threads:[~2011-06-15 13:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 10:41 [PATCH 0/1] Enable to set RTC for beagleboard Jingdong Lu
2011-06-15 10:41 ` [PATCH 1/1] RTC: Enable to set RTC Jingdong Lu
2011-06-15 13:21 ` Bruce Ashfield [this message]
2011-06-15 13:25   ` [PATCH 0/1] Enable to set RTC for beagleboard Koen Kooi
2011-06-15 13:31     ` Bruce Ashfield
2011-06-15 16:48       ` Darren Hart
2011-06-15 16:52         ` Bruce Ashfield
2011-06-15 17:33           ` Darren Hart
2011-06-16  2:23             ` Lu Jingdong
2011-06-16  4:25               ` Bruce Ashfield
2011-06-16 14:45                 ` Darren Hart
2011-06-16 14:59                   ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF8B1D7.8050208@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=dvhart@linux.intel.com \
    --cc=jingdong.lu@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.