On 15/06/11 14:38, Andrew Cooper wrote: > > On 15/06/11 13:42, Keir Fraser wrote: >> On 15/06/2011 13:33, "Andrew Cooper" wrote: >> >>> It turns out that we do require apic_boot_mode to be accessible outside >>> in a later reformatted patch so that cant be static any more. >>> >>> Suggested changes for acpi_mode_to_str have been taken, along with >>> removing its declaration from apic.h and putting it at the top of apic.c >> I applied some of you series already to xen-unstable tip. Please re-send the >> remaining bits you need as a new series against tip. >> >> -- Keir > Ah - I am working against the wrong unstable. Here is the change > against staging unstable. > > Also, is it wise having extern enum apic_mode > current_local_apic_mode(void); is apic.h if the function itself is > static inside apic.c? > Sorry - previous patch was still against the wrong repo. This is correctly against staging. -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com