From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 4 of 7] APIC: record local APIC state on boot [Reformatted] Date: Wed, 15 Jun 2011 15:49:55 +0100 Message-ID: <4DF8C693.50901@citrix.com> References: <4DF8B5DE.5090208@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030204030700090201090406" Return-path: In-Reply-To: <4DF8B5DE.5090208@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --------------030204030700090201090406 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 15/06/11 14:38, Andrew Cooper wrote: > > On 15/06/11 13:42, Keir Fraser wrote: >> On 15/06/2011 13:33, "Andrew Cooper" wrote: >> >>> It turns out that we do require apic_boot_mode to be accessible outside >>> in a later reformatted patch so that cant be static any more. >>> >>> Suggested changes for acpi_mode_to_str have been taken, along with >>> removing its declaration from apic.h and putting it at the top of apic.c >> I applied some of you series already to xen-unstable tip. Please re-send the >> remaining bits you need as a new series against tip. >> >> -- Keir > Ah - I am working against the wrong unstable. Here is the change > against staging unstable. > > Also, is it wise having extern enum apic_mode > current_local_apic_mode(void); is apic.h if the function itself is > static inside apic.c? > Sorry - previous patch was still against the wrong repo. This is correctly against staging. -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com --------------030204030700090201090406 Content-Type: text/x-patch; name="apic-record-boot-mode.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="apic-record-boot-mode.patch" APIC: record local APIC state on boot Xen does not store the boot local APIC state which leads to problems when shutting down for a kexec jump. This patch records the boot state so we can return to the boot state when kexecing. Signed-off-by: Andrew Cooper diff -r cac82bc1ea23 xen/arch/x86/apic.c --- a/xen/arch/x86/apic.c Wed Jun 15 13:33:58 2011 +0100 +++ b/xen/arch/x86/apic.c Wed Jun 15 14:36:02 2011 +0100 @@ -78,7 +78,7 @@ boolean_param("x2apic", opt_x2apic); * Bootstrap processor local APIC boot mode - so we can undo our changes * to the APIC state. */ -static enum apic_mode apic_boot_mode = APIC_MODE_INVALID; +enum apic_mode apic_boot_mode = APIC_MODE_INVALID; bool_t __read_mostly x2apic_enabled = 0; bool_t __read_mostly directed_eoi_enabled = 0; --------------030204030700090201090406 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------030204030700090201090406--