From: Maarten Lankhorst <m.b.lankhorst@gmail.com>
To: Hugo Mills <hugo@carfax.org.uk>,
Chris Mason <chris.mason@oracle.com>,
linux-btrfs@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] btrfs: Remove all sysfs entries
Date: Wed, 15 Jun 2011 18:02:16 +0200 [thread overview]
Message-ID: <4DF8D788.4050105@gmail.com> (raw)
In-Reply-To: <20110615103431.GA15127@carfax.org.uk>
Op 15-06-11 12:34, Hugo Mills schreef:
> On Wed, Jun 15, 2011 at 10:40:31AM +0200, Maarten Lankhorst wrote:
>> Seems that currently none of the sysfs are created any more, so just
>> remove sysfs support entirely.
>>
>> Fixes compiling warnings in 3.0rc3
> I would actually like to retain sysfs support -- the current
> entries may not be used (or useful, or in the right place, or even
> visible these days), but there's plenty of things that could and
> should go in sysfs from btrfs.
>
> So, please do remove the unwanted/unused file entries, but could
> you leave the sysfs file itself, and the (limited) bits that create
> the btrfs subdir? Otherwise, I'm going to be putting it all back in
> this weekend when I get the time to revisit Goffredo's old sysfs
> patch...
Currently sysfs.c is just 2 function calls, rest is unused, so I'll wait then.
Will in_sysfs in struct btrfs_root be used again? Currently it's not
used but only assigned zero.
~Maarten
prev parent reply other threads:[~2011-06-15 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 8:40 [PATCH v2] btrfs: Remove all sysfs entries Maarten Lankhorst
2011-06-15 10:34 ` Hugo Mills
2011-06-15 15:54 ` Mitch Harder
2011-06-15 15:54 ` Mitch Harder
2011-06-15 16:01 ` Hugo Mills
2011-06-15 16:02 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8D788.4050105@gmail.com \
--to=m.b.lankhorst@gmail.com \
--cc=chris.mason@oracle.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.