From: "Ortwin Glück" <odi@odi.ch>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.39.1 input regression
Date: Thu, 16 Jun 2011 09:44:00 +0200 [thread overview]
Message-ID: <4DF9B440.9070500@odi.ch> (raw)
In-Reply-To: <20110615150326.GA7128@suse.de>
On 15.06.2011 17:03, Greg KH wrote:
> On Wed, Jun 15, 2011 at 09:16:47AM +0200, Ortwin Glück wrote:
>> Hi Greg,
>>
>> This patch in 2.6.39.1 breaks magicmouse support for me completely.
>> a5ccaac64c17ce3cc1878a6d479a6f1b16092c24
>> HID: magicmouse: ignore 'ivalid report id' while switching modes
>>
>> The device will no longer work at all:
>> magicmouse 0005:05AC:030D.0005: input,hidraw2: BLUETOOTH HID v0.84 Mouse
>> [gandalf mouse] on 7C:6D:62:9F:DB:2D
>> magicmouse 0005:05AC:030D.0005: unable to request touch data (2)
>>
>> Fine in previous kernels.
>
> This has been discussed already, and it should be fixed in Linus's tree
> right now, right?
>
> If so, can someone please send stable@kernel.org the proper fix for
> this?
>
> thanks,
>
> greg k-h
If it's in Linus' tree then I can't find it. To me this issue just looks
like a silly typo anyway:
- if (ret != sizeof(feature)) {
+ if (ret != -EIO) {
hid_err(hdev, "unable to request touch data (%d)\n", ret);
goto err_stop_hw;
}
Should this not be (ret == -EIO)?
Ortwin
next prev parent reply other threads:[~2011-06-16 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 7:16 2.6.39.1 input regression Ortwin Glück
2011-06-15 15:03 ` Greg KH
2011-06-16 7:44 ` Ortwin Glück [this message]
2011-06-16 10:03 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF9B440.9070500@odi.ch \
--to=odi@odi.ch \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.