Re: [PATCH 1/1] RTC: Ensure msecure is mux'd to be able to set RTC

[Bruce Ashfield <bruce.ashfield@windriver.com>]

On 06/16/11 03:27, Koen Kooi wrote:
>
> Op 16 jun 2011, om 08:07 heeft Jingdong Lu het volgende geschreven:
>
>> From: Jingdong Lu<jingdong.lu@windriver.com>
>>
>> commit e2a346a2a054f702fd76f328ff747b9ad9264a4c from git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
>
> When I do 'git show e2a346a2a054f702fd76f328ff747b9ad9264a4' I get:
>
> commit e2a346a2a054f702fd76f328ff747b9ad9264a4c
> Author: Alexander Holler<holler@ahsoftware.de>
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Date:   Tue Apr 5 15:40:08 2011 +0200
>
>      arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC
>
>      Without msecure beeing high it isn't possible to set (or start)
>      the RTC.
>
>      Tested with a BeagleBoard C4.
>
>      Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>      Signed-off-by: Tony Lindgren<tony@atomide.com>
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index be71426..d64ed97 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -579,6 +579,9 @@ static void __init omap3_beagle_init(void)
>          omap_nand_flash_init(NAND_BUSWIDTH_16, omap3beagle_nand_partitions,
>                               ARRAY_SIZE(omap3beagle_nand_partitions));
>
> +       /* Ensure msecure is mux'd to be able to set the RTC. */
> +       omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
> +
>          /* Ensure SDRC pins are mux'd for self-refresh */
>          omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
>          omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
>
>
> So if you're going to change the author, you'd also need to remove the SOBs.

It's likely just a glitch in patch generation.

Jindong: did you cherry-pick or git am this for the import
into your tree ? Or did you use another technique ?
If done properly, the author is always maintained in our
imported patches.

Cheers,

Bruce

>
>>
>> arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC.
>> "Msecure" signal provides for protection of the RTC register in TPS65950 be
>> disabling that function via a control signal from the OMAP3530. So ensure
>> msecure is mux'd to be able to set the RTC.
>>
>> Tested with a BeagleBoard C4.
>> Fixes bug [YOCTO #767]
>>
>> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>> Signed-off-by: Tony Lindgren<tony@atomide.com>
>> Integrated-by: Jingdong Lu<jingdong.lu@windriver.com>
>> ---
>> arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
>> index af1166b..925c0b3 100644
>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
>> @@ -580,6 +580,9 @@ static void __init omap3_beagle_init(void)
>> 	usb_ehci_init(&ehci_pdata);
>> 	omap3beagle_flash_init();
>>
>> +	/* Ensure msecure is mux'd to be able to set the RTC. */
>> +	omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH);
>> +
>> 	/* Ensure SDRC pins are mux'd for self-refresh */
>> 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
>> 	omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);
>> --
>> 1.7.0.4
>>
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto