From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXCl7-0006Av-Fe for qemu-devel@nongnu.org; Thu, 16 Jun 2011 09:37:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXCl4-0006dV-98 for qemu-devel@nongnu.org; Thu, 16 Jun 2011 09:37:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXCl3-0006dP-Sq for qemu-devel@nongnu.org; Thu, 16 Jun 2011 09:37:18 -0400 Message-ID: <4DFA0709.8040408@redhat.com> Date: Thu, 16 Jun 2011 15:37:13 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1308158555-6324-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1308158555-6324-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/usb-ohci.c: Fix handling of remote wakeup corner cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 06/15/11 19:22, Peter Maydell wrote: > Correct a number of minor errors in the OHCI wakeup implementation: > * when the port is suspended but the controller is not, raise RHSC > * when the controller is suspended but the port is not, raise RD > * when the controller is suspended, move it to resume state > > These fix some edge cases where a USB device might not successfully get > the attention of the guest OS if it tried to do so at the wrong time. > > Signed-off-by: Peter Maydell Patch applied. thanks, Gerd