bbappend and require

bbappend and require

[Ilya Yanok]

Hi guys,

Is bbappend supposed to work when the recipe is included (with require)
from another recipe?

We want to add some package to SDK so I've created
task-sdk-host.bbappend in our layer and it works fine. But when I'm
building task-qte-toolchain-host (which requires task-sdk-host) bbappend
file seems to be ignored. Is it to be expected?

It's no problem to create task-qte-toolchain.bbappend also, and this
fixes the problem but what should be the right behavior of require wrt
bbapend?

Thanks.

Regards, Ilya.

Re: bbappend and require

[Mark Hatle]

On 6/16/11 11:19 AM, Ilya Yanok wrote:
> Hi guys,
> 
> Is bbappend supposed to work when the recipe is included (with require)
> from another recipe?
> 
> We want to add some package to SDK so I've created
> task-sdk-host.bbappend in our layer and it works fine. But when I'm
> building task-qte-toolchain-host (which requires task-sdk-host) bbappend
> file seems to be ignored. Is it to be expected?
> 
> It's no problem to create task-qte-toolchain.bbappend also, and this
> fixes the problem but what should be the right behavior of require wrt
> bbapend?

This sounds like a bug to me.  Which version of Poky/Yocto are you currently
using, and can you give us a simple reproducer.  (Better yet, file a bug in the
bugzilla.yoctoproject.org... if you can't do so, I'll be happy to file it if I
can get a reproducer.)

--Mark

> Thanks.
> 
> Regards, Ilya.
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

Re: bbappend and require

[Chris Larson]

On Thu, Jun 16, 2011 at 11:28 AM, Mark Hatle <mark.hatle@windriver.com> wrote:
> On 6/16/11 11:19 AM, Ilya Yanok wrote:
>> Hi guys,
>>
>> Is bbappend supposed to work when the recipe is included (with require)
>> from another recipe?
>>
>> We want to add some package to SDK so I've created
>> task-sdk-host.bbappend in our layer and it works fine. But when I'm
>> building task-qte-toolchain-host (which requires task-sdk-host) bbappend
>> file seems to be ignored. Is it to be expected?
>>
>> It's no problem to create task-qte-toolchain.bbappend also, and this
>> fixes the problem but what should be the right behavior of require wrt
>> bbapend?
>
> This sounds like a bug to me.  Which version of Poky/Yocto are you currently
> using, and can you give us a simple reproducer.  (Better yet, file a bug in the
> bugzilla.yoctoproject.org... if you can't do so, I'll be happy to file it if I
> can get a reproducer.)

I wouldn't think this is a bug. A bbappend applies to the recipe
itself, not any of the files it includes. This is Working As Designed,
as far as I can tell.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: bbappend and require

[Mark Hatle]

On 6/16/11 1:39 PM, Chris Larson wrote:
> On Thu, Jun 16, 2011 at 11:28 AM, Mark Hatle <mark.hatle@windriver.com> wrote:
>> On 6/16/11 11:19 AM, Ilya Yanok wrote:
>>> Hi guys,
>>>
>>> Is bbappend supposed to work when the recipe is included (with require)
>>> from another recipe?
>>>
>>> We want to add some package to SDK so I've created
>>> task-sdk-host.bbappend in our layer and it works fine. But when I'm
>>> building task-qte-toolchain-host (which requires task-sdk-host) bbappend
>>> file seems to be ignored. Is it to be expected?
>>>
>>> It's no problem to create task-qte-toolchain.bbappend also, and this
>>> fixes the problem but what should be the right behavior of require wrt
>>> bbapend?
>>
>> This sounds like a bug to me.  Which version of Poky/Yocto are you currently
>> using, and can you give us a simple reproducer.  (Better yet, file a bug in the
>> bugzilla.yoctoproject.org... if you can't do so, I'll be happy to file it if I
>> can get a reproducer.)
> 
> I wouldn't think this is a bug. A bbappend applies to the recipe
> itself, not any of the files it includes. This is Working As Designed,
> as far as I can tell.

I misunderstood the issue then.. I thought what was being described was..

task-sdk-host.bb had a task-sdk-host.bbappend

task-qte-toolchain-host.bb requires task-sdk-host..

building task-sdk-host "worked", building "task-qte-toolchain-host" didn't.  If
that's not the case... then Chris is correct.. this is as designed.  a bbappend
only affects the item being appended.

--Mark

Re: bbappend and require

[Chris Larson]

On Thu, Jun 16, 2011 at 12:02 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
> On 6/16/11 1:39 PM, Chris Larson wrote:
>> On Thu, Jun 16, 2011 at 11:28 AM, Mark Hatle <mark.hatle@windriver.com> wrote:
>>> On 6/16/11 11:19 AM, Ilya Yanok wrote:
>>>> Hi guys,
>>>>
>>>> Is bbappend supposed to work when the recipe is included (with require)
>>>> from another recipe?
>>>>
>>>> We want to add some package to SDK so I've created
>>>> task-sdk-host.bbappend in our layer and it works fine. But when I'm
>>>> building task-qte-toolchain-host (which requires task-sdk-host) bbappend
>>>> file seems to be ignored. Is it to be expected?
>>>>
>>>> It's no problem to create task-qte-toolchain.bbappend also, and this
>>>> fixes the problem but what should be the right behavior of require wrt
>>>> bbapend?
>>>
>>> This sounds like a bug to me.  Which version of Poky/Yocto are you currently
>>> using, and can you give us a simple reproducer.  (Better yet, file a bug in the
>>> bugzilla.yoctoproject.org... if you can't do so, I'll be happy to file it if I
>>> can get a reproducer.)
>>
>> I wouldn't think this is a bug. A bbappend applies to the recipe
>> itself, not any of the files it includes. This is Working As Designed,
>> as far as I can tell.
>
> I misunderstood the issue then.. I thought what was being described was..
>
> task-sdk-host.bb had a task-sdk-host.bbappend
>
> task-qte-toolchain-host.bb requires task-sdk-host..
>
> building task-sdk-host "worked", building "task-qte-toolchain-host" didn't.  If
> that's not the case... then Chris is correct.. this is as designed.  a bbappend
> only affects the item being appended.

Nature of the terminology being used, it's unclear whether 'require'
means 'recipe dependency' or 'the bitbake "require" command' in this
context :)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: bbappend and require

[Paul Eggleton]

On Thursday 16 June 2011 20:21:57 Chris Larson wrote:
> Nature of the terminology being used, it's unclear whether 'require'
> means 'recipe dependency' or 'the bitbake "require" command' in this
> context :)

I think it's clear from Ilya's message that he means the require command. To 
me it's not clear however whether using "require" (or "include" for that 
matter) means that bbappends should also be included. I can certainly see how 
someone could assume that they would be.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: bbappend and require

[Chris Larson]

On Fri, Jun 17, 2011 at 3:44 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday 16 June 2011 20:21:57 Chris Larson wrote:
>> Nature of the terminology being used, it's unclear whether 'require'
>> means 'recipe dependency' or 'the bitbake "require" command' in this
>> context :)
>
> I think it's clear from Ilya's message that he means the require command. To
> me it's not clear however whether using "require" (or "include" for that
> matter) means that bbappends should also be included. I can certainly see how
> someone could assume that they would be.

Agreed, but that's not the case currently. Perhaps we should improve
the documentation? People *have*, however, requested the ability to
bbappend to .inc's before, which is what this would get us, but would
mean substantial changes to how bitbake implements it. We have bigger
priorities :)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: bbappend and require

[IlyaYanok]

Hi,

Chris Larson <clarson@...> writes:
> > I think it's clear from Ilya's message that he means the require command. To
> > me it's not clear however whether using "require" (or "include" for that
> > matter) means that bbappends should also be included. I can certainly see how
> > someone could assume that they would be.

Thanks for the explanation guys! That's what I wanted to hear.

Regards, Ilya.